Page MenuHomePhabricator

MobileFrontend should not contain ConfirmEdit specific styling
Closed, ResolvedPublic

Description

I'd like to remove some CSS rules from MobileFrontend that relate to Confirm Edit.

To do this I will

  • Enable ConfirmEdit's styles in mobile mode
  • Update Minerva' skinStyles to retain the current styling
  • Drop the CSS in MobileFrontend, merging the mobile.ajax.styles module into mobile.startup

Benefits:

  • The reload icon will be defined in one place - ConfirmEdit - @Volker_E will follow up with standardising that icon.

Sign off steps

Jon to check with Volker that desktop and mobile appearance are acceptable.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 15 2019, 12:11 AM

Change 484327 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/ConfirmEdit@master] Enable FancyCaptcha's styles on mobile

https://gerrit.wikimedia.org/r/484327

Change 484328 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Drop usage of mobile.ajax.styles

https://gerrit.wikimedia.org/r/484328

Change 484329 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] mobile.ajax styles is merged into mobile.startup

https://gerrit.wikimedia.org/r/484329

Change 484327 merged by jenkins-bot:
[mediawiki/extensions/ConfirmEdit@master] Enable FancyCaptcha's styles on mobile

https://gerrit.wikimedia.org/r/484327

Change 484328 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Drop usage of mobile.ajax.styles

https://gerrit.wikimedia.org/r/484328

Change 484746 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Separate ConfirmEdit styles from Login styles

https://gerrit.wikimedia.org/r/484746

Change 484300 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/ConfirmEdit@master] Standardise captcha reload icon

https://gerrit.wikimedia.org/r/484300

Production (now):

beta cluster (now)

After the two ConfirmEdit (pending icon color change) and Minerva patches:

Added feedback on the patch about unnecessary link appearance differences on desktop/mobile and padding…

Revised patchset 2:

(No changes to desktop)

Change 484329 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] mobile.ajax styles is merged into mobile.startup

https://gerrit.wikimedia.org/r/484329

Change 484300 merged by jenkins-bot:
[mediawiki/extensions/ConfirmEdit@master] Standardise captcha reload icon

https://gerrit.wikimedia.org/r/484300

Change 484746 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Separate ConfirmEdit styles from Login styles

https://gerrit.wikimedia.org/r/484746

Jdlrobson triaged this task as Normal priority.
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Incoming to Needs Prioritization on the Readers-Web-Backlog board.
Jdlrobson closed this task as Resolved.Jan 22 2019, 8:42 PM

Checked with @Volker_E and we're happy with the state of things going out on the train.