Page MenuHomePhabricator

$openid seems to be an array
Closed, ResolvedPublic

Description

Author: the.real.singesang

Description:
$openid = this->getUserUrl($user); assigns an array. strlen of an empty array also returns something greater 0. so it should check, if the array is empty then

possible solution:

Index: SpecialOpenIDServer.body.php

  • SpecialOpenIDServer.body.php (revision 52244)

+++ SpecialOpenIDServer.body.php (working copy)
@@ -235,7 +235,7 @@

$openid = $this->getUserUrl( $user );
  • if ( isset( $openid ) && strlen( $openid ) > 0 ) {

+ if ( isset( $openid ) && strlen( $openid[0] ) > 0 ) {

        wfDebug( "OpenID: Not one of our users; logs in with OpenID.\n" );
        return $request->answer( false, $this->serverUrl() );
}

Version: unspecified
Severity: minor

Details

Reference
bz19457

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:39 PM
bzimport set Reference to bz19457.
bzimport added a subscriber: Unknown Object (MLST).