Page MenuHomePhabricator

Syntax check should be consistent with actual parsing
Open, Needs TriagePublic

Description

Right now, when testing the syntax of a filter, all we do is disable short circuit evaluation and parse it. While this could seem a sane approach, it has underlying bugs which cause some patterns to fail with actual parsing (i.e. short-circuit enabled), but be reported as correct by the syntax checker.
Syntax checking should probably use a different strategy and avoid fully parsing the code, with or without short-circuit enabled. T204654 is related.

Examples of this inconsistency: T214642, T214674, T218906.

Event Timeline

Daimona created this task.Jan 24 2019, 9:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 24 2019, 9:44 PM
Daimona moved this task from Backlog to Future on the User-Daimona board.
Daimona updated the task description. (Show Details)Mar 21 2019, 3:05 PM