Page MenuHomePhabricator

Transclusion of entirely blank page with custom numbering, corrupts page numbering display on transclusion (due to overlap?).
Closed, InvalidPublic

Description

https://en.wikisource.org/wiki/The_Return_of_Sherlock_Holmes,_1905_edition/Chapter_1

The page numbering is displayed correctly, until an image/blank page combination in the transclusion intervenes. It correctly displays the page number for the image (Page21) (a custom string) the "blank" (Page 22) (of the Djvu), but fails to pick up the page number for Page 23 (of the Djvu) which immediately follows the blank.

The scripts should be recognising a blank page in the transclusion and amending how it places the numbering accordingly.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 27 2019, 3:01 PM

A seperate issue is that previously page 21 was defined as "(8)" in the pagelist tag, (see the history of the hhttps://en.wikisource.org/w/index.php?title=Index%3AThe_Return_of_Sherlock_Holmes%2C_edition_published_in_1905_by_McClure%2C_Phillips_%26_Co.%2C_New_York..djvu&type=revision&diff=9071942&oldid=6138746 ) which inadvertently suppressed the display of subsequent page numbers to the left of the transclusion, after it was encountered.

It is not unreasonable to expect core functionality such as this to be robust...

ShakespeareFan00 renamed this task from Blank page in transcluded page, corrupts page numbering to Blank page with custom numbering, corrupts page numbering display on transclusion..Jan 27 2019, 3:48 PM
Billinghurst closed this task as Invalid.Jan 28 2019, 7:56 AM
Billinghurst added a subscriber: Billinghurst.

This is completely part of the javascript page numbering functionality, and how it hides page numbers when they are squashed together preventing overlap, as that they don't fit in the same space. Simply use the exclude functionality of <pages> to omit the first blank page so it doesn't obscure the subsequent page number.

ShakespeareFan00 reopened this task as Open.Jan 28 2019, 10:02 AM

Re-opening because I still consider this a bug. Whilst the work-around suggested, is indeed a reasonable "temporary" solution, it doesn't fully resolve the issue. It is not unreasonable for the transclusion functionality /page numbering script to recognize an entirely blank page and suppress or amend display of numbering which would overlap, without having to explicitly make use of excludes.

ShakespeareFan00 renamed this task from Blank page with custom numbering, corrupts page numbering display on transclusion. to Transclusion of entirely blank page with custom numbering, corrupts page numbering display on transclusion (due to overlap?)..EditedJan 28 2019, 10:08 AM

The original example in this was temporarily repaired using the suggested work-around, see https://en.wikisource.org/wiki/The_Return_of_Sherlock_Holmes,_1905_edition/Chapter_3 for an example of where the reported issue now arises.

ShakespeareFan00 triaged this task as Low priority.Jan 28 2019, 10:47 AM
Billinghurst closed this task as Invalid.Jan 28 2019, 10:58 AM

It is not a function of transclusion, this solely is part of English Wikisource's page numbering javascript, there is nothing for a phabricator ticket.

Stop trying to make proofreadpage do the job of thinking that should be done by the editor, and by the wiks decision-making for how it portrays works.