Page MenuHomePhabricator

Cancel button in Create Task form always leads to Maniphest
Closed, DeclinedPublicBUG REPORT

Description

The Cancel button in the Create Task form links to Maniphest, rather than taking you back to whatever page you were previously on.

Steps to reproduce:

  1. Go to https://phabricator.wikimedia.org/
  2. Click on the "Favorites menu" () -> Create Task (Simple)
  3. Click on the Cancel button

Actual result:
You end up on https://phabricator.wikimedia.org/maniphest/.

Expected result:
You end up on https://phabricator.wikimedia.org/, since that was the previous page.

Event Timeline

Aklapper triaged this task as Lowest priority.Feb 25 2019, 6:48 AM
Aklapper edited projects, added Phabricator (Upstream); removed Phabricator.
Sebastian_Berlin-WMSE changed the subtype of this task from "Task" to "Bug Report".Feb 28 2019, 7:08 AM

This is defined in https://we.phorge.it/source/phorge/browse/master/src/applications/transactions/editengine/PhabricatorEditEngine.php$561-563 :
protected function getObjectCreateCancelURI($object) does return $this->getApplication()->getApplicationURI();.

I don't even see what's a reliable and secure technical approach to implement this proposal, if I interpret correctly https://stackoverflow.com/questions/5285031/back-to-previous-page-with-header-location-in-php . Any opinions / recommendations?

Folks are free to use the "Back" button of their browser, I'd say. I don't see how the current behavior is a bug...