Page MenuHomePhabricator

Inconsistant Skin options
Closed, DeclinedPublic

Description

Author: asvr90

Description:
Using V1.3.0 the following Skins are optioned in the user Preference list when logged
in.

Classic
Nostalgia
Cologne Blue
MonoBook
MySkin

However, in the stylesheets directory the following appears

davinci <dir>
mono <dir>
monobook <dir>
myskin <dir>
wikistandard.css
nostalgia.css
cologneblue.css

  • as well as some other style sheets and files. There are clearly some styles that

are offered that do not relate to style sheets or directories. Similarly there are
style directories that are not offered as preferance options (ie davinci).

Looking at include/Skin.php there are some options commented out

#$wgValidSkinNames['davinci'] = 'DaVinci';
#$wgValidSkinNames['mono'] = 'Mono';
#$wgValidSkinNames['monobookminimal'] = 'MonoBookMinimal';

Should this be more consistant. EG. each style should have it's own directory under
stylesheets, and if it's not going to be offered as an option, then perhaps it should
be removed - or a refrenece to it in the Release notes saying it's disabled.


Version: 1.3.x
Severity: minor
OS: Linux
Platform: PC

Details

Reference
bz157

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 6:43 PM
bzimport set Reference to bz157.
bzimport added a subscriber: Unknown Object (MLST).

Those are just leftover files from development, and are not currently functional.