Page MenuHomePhabricator

Move setBigSelects() to DatabaseMysql
Closed, ResolvedPublic

Description

The implementation for setBigSelects() should be in DatabaseMysql, not in DatabaseBase. Attaching a patch to move it where it belongs and make the DatabaseBase a no-op (not abstract, because the vast majority of subclasses won't even need to implement this at all).


Version: 1.16.x
Severity: normal

Details

Reference
bz19591

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:41 PM
bzimport set Reference to bz19591.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 6310
Patch to fix this

Stupid bugzilla didn't attach on submittal.

Attached:

Eh, got to it myself. Done in r52951