Page MenuHomePhabricator
Create Task
Maniphest T216390

[Extension:LastUserLogin] Remove the usage of global variable $wgUser, $wgRequest, $wgOut, $wgLang
Closed, ResolvedPublic
Actions

Description

Problem

Now we are replacing the global variable by getting the context. The Classes which extends SpecialPage can directly access the context by $this.

Solution

Replace

  1. $wgUser with $this->getUser()
  2. $wgRequest with $this->getRequest()
  3. $wgOut with $this->getOutput()
  4. $wgLang with $this->getLanguage()

in LastUserLogin.body.php. If there are multiple usages then use a variable to store context instead of calling $this again and again.

Level

Easy

Reserved for Mini-MWT at VVIT (Feb 2019)

Details

SubjectRepoBranchLines +/-
LastUserLogin: Replace the usage of global variablesmediawiki/extensions/LastUserLoginmaster+13 -10
Replaced rawParams() with plaintextParams()mediawiki/extensions/GrowthExperimentsmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Jayprakash12345 created this task.Feb 18 2019, 10:10 AM
Restricted Application added a project: User-Jayprakash12345. · View Herald TranscriptFeb 18 2019, 10:10 AM
Jayprakash12345 moved this task from General coordination to Task for Students on the Mini-MWT at VVIT (Feb 2019) board.Feb 18 2019, 10:10 AM
Jayprakash12345 removed a project: User-Jayprakash12345.
Liuxinyu970226 added a subscriber: Sophivorus.Feb 19 2019, 10:08 AM
Asrija1 claimed this task.Feb 23 2019, 4:59 AM
Asrija1 removed Asrija1 as the assignee of this task.Feb 23 2019, 5:13 AM
Asrija1 subscribed.
Asrija1 unsubscribed.Feb 23 2019, 5:16 AM
gerritbot subscribed.Feb 23 2019, 5:37 AM

Change 492437 had a related patch set uploaded (by Naga sai sravanth; owner: Naga sai sravanth):
[mediawiki/extensions/GrowthExperiments@master] Replaced rawParams() with plaintextParams()

https://gerrit.wikimedia.org/r/492437

gerritbot added a project: Patch-For-Review.Feb 23 2019, 5:37 AM
Naga_sai_sravanth mentioned this in rEGRE8dc154537d06: Replaced rawParams() with plaintextParams().Feb 23 2019, 5:39 AM
SuswethaK claimed this task.Feb 23 2019, 5:51 AM
gerritbot added a comment.Feb 23 2019, 6:22 AM

Change 492441 had a related patch set uploaded (by SuswethaK; owner: SuswethaK):
[mediawiki/extensions/LastUserLogin@master] Remove the usage of global variable $wgUser, $wgRequest, $wgOut, $wgLang.

https://gerrit.wikimedia.org/r/492441

gerritbot added a comment.Feb 24 2019, 1:29 PM

Change 492437 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Replaced rawParams() with plaintextParams()

https://gerrit.wikimedia.org/r/492437

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.19; 2019-02-26).Feb 24 2019, 2:00 PM
Jayprakash12345 removed a project: MW-1.33-notes (1.33.0-wmf.19; 2019-02-26).Feb 24 2019, 2:02 PM
gerritbot added a comment.Mar 21 2019, 9:06 AM

Change 492441 had a related patch set uploaded (by D3r1ck01; owner: SuswethaK):
[mediawiki/extensions/LastUserLogin@master] LastUserLogin: Replace the usage of global variables

https://gerrit.wikimedia.org/r/492441

gerritbot added a comment.Apr 6 2019, 1:24 PM

Change 492441 merged by jenkins-bot:
[mediawiki/extensions/LastUserLogin@master] LastUserLogin: Replace the usage of global variables

https://gerrit.wikimedia.org/r/492441

Jdforrester-WMF closed this task as Resolved.Apr 6 2019, 7:59 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF subscribed.

Thank you!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits