Page MenuHomePhabricator
Create Task
Maniphest T216394

[Extension:ImportUsers] Remove the usage of global variable $wgUser, $wgOut, $wgLang
Closed, ResolvedPublic
Actions

Description

Problem

Now we are replacing the global variable by getting the context. The Classes which extends SpecialPage can directly access the context by $this.

Solution

Replace

  1. $wgUser with $this->getUser()
  2. $wgOut with $this->getOutput()
  3. $wgLang with $this->getLanguage()

in ImportUsers_body.php. If there are multiple usages then use a variable to store context instead of calling $this again and again.

Level

Easy

Reserved for Mini-MWT at VVIT (Feb 2019)

Details

SubjectRepoBranchLines +/-
Replace the usage of global variable $wgUser, $wgOut, $wgLangmediawiki/extensions/ImportUsersmaster+12 -11
Customize query in gerrit

Event Timeline

Jayprakash12345 created this task.Feb 18 2019, 10:48 AM
Restricted Application added a project: User-Jayprakash12345. · View Herald TranscriptFeb 18 2019, 10:48 AM
Jayprakash12345 moved this task from General coordination to Task for Students on the Mini-MWT at VVIT (Feb 2019) board.Feb 18 2019, 10:48 AM
Jayprakash12345 removed a project: User-Jayprakash12345.
HarikaMekala claimed this task.Feb 23 2019, 5:44 AM
gerritbot subscribed.Feb 23 2019, 6:11 AM

Change 492440 had a related patch set uploaded (by HarikaMekala; owner: HarikaMekala):
[mediawiki/extensions/ImportUsers@master] emove the usage of global variable $wgUser, $wgOut, $wgLang

https://gerrit.wikimedia.org/r/492440

gerritbot added a project: Patch-For-Review.Feb 23 2019, 6:11 AM
gerritbot added a comment.Apr 5 2019, 8:47 PM

Change 492440 had a related patch set uploaded (by Jforrester; owner: HarikaMekala):
[mediawiki/extensions/ImportUsers@master] Replace the usage of global variable $wgUser, $wgOut, $wgLang

https://gerrit.wikimedia.org/r/492440

gerritbot added a comment.Apr 5 2019, 11:07 PM

Change 492440 merged by jenkins-bot:
[mediawiki/extensions/ImportUsers@master] Replace the usage of global variable $wgUser, $wgOut, $wgLang

https://gerrit.wikimedia.org/r/492440

Jdforrester-WMF closed this task as Resolved.Apr 5 2019, 11:15 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF subscribed.

Thank you!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits