Page MenuHomePhabricator

Iwbacklinks returns pageid as string instead of int
Closed, ResolvedPublic

Description

As noted here, the Iwbacklinks module returns the pageid as a string instead of as an int, as most other modules do. I've poked through the code, and don't see any obvious source for the problem, so it's possible it's more than just Iwbacklinks that's affected. (Note: I haven't done much PHP work, so I may have missed something that'll jump out to others.) The links below demonstrate the difference.

Iwbacklinks: https://en.wikipedia.org/w/api.php?action=query&list=iwbacklinks
Backlinks property: https://en.wikipedia.org/w/api.php?action=query&list=backlinks&bltitle=Main%20page

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 24 2019, 9:06 PM
RobinHood70 updated the task description. (Show Details)Feb 24 2019, 9:09 PM

Change 492575 had a related patch set uploaded (by Setian; owner: Setian):
[mediawiki/core@master] Return the page_id in list=iwbacklinks as an int rather than string

https://gerrit.wikimedia.org/r/492575

That was fast! It looks like there's another report here that just came in recently. I hadn't noticed it before I posted.

https://www.mediawiki.org/wiki/API_talk:Langbacklinks

Change 492578 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Return the page_id in list=lblbacklinks as an int

https://gerrit.wikimedia.org/r/492578

Change 492575 merged by jenkins-bot:
[mediawiki/core@master] Return the page_id in list=iwbacklinks as an int rather than string

https://gerrit.wikimedia.org/r/492575

Change 492578 merged by jenkins-bot:
[mediawiki/core@master] Return the page_id in list=langbacklinks as an int

https://gerrit.wikimedia.org/r/492578

Anomie closed this task as Resolved.Feb 25 2019, 3:40 PM

Change 493029 had a related patch set uploaded (by Reedy; owner: Setian):
[mediawiki/core@REL1_32] Return the page_id in list=iwbacklinks as an int rather than string

https://gerrit.wikimedia.org/r/493029

Change 493030 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@REL1_32] Return the page_id in list=langbacklinks as an int

https://gerrit.wikimedia.org/r/493030

Change 493033 had a related patch set uploaded (by Reedy; owner: Setian):
[mediawiki/core@REL1_31] Return the page_id in list=iwbacklinks as an int rather than string

https://gerrit.wikimedia.org/r/493033

Change 493034 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@REL1_31] Return the page_id in list=langbacklinks as an int

https://gerrit.wikimedia.org/r/493034

Change 493037 had a related patch set uploaded (by Reedy; owner: Setian):
[mediawiki/core@REL1_30] Return the page_id in list=iwbacklinks as an int rather than string

https://gerrit.wikimedia.org/r/493037

Change 493038 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@REL1_30] Return the page_id in list=langbacklinks as an int

https://gerrit.wikimedia.org/r/493038

Change 493041 had a related patch set uploaded (by Reedy; owner: Setian):
[mediawiki/core@REL1_27] Return the page_id in list=iwbacklinks as an int rather than string

https://gerrit.wikimedia.org/r/493041

Change 493042 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@REL1_27] Return the page_id in list=langbacklinks as an int

https://gerrit.wikimedia.org/r/493042

Change 493029 merged by jenkins-bot:
[mediawiki/core@REL1_32] Return the page_id in list=iwbacklinks as an int rather than string

https://gerrit.wikimedia.org/r/493029

Change 493030 merged by jenkins-bot:
[mediawiki/core@REL1_32] Return the page_id in list=langbacklinks as an int

https://gerrit.wikimedia.org/r/493030

Change 493033 merged by jenkins-bot:
[mediawiki/core@REL1_31] Return the page_id in list=iwbacklinks as an int rather than string

https://gerrit.wikimedia.org/r/493033

Change 493034 merged by jenkins-bot:
[mediawiki/core@REL1_31] Return the page_id in list=langbacklinks as an int

https://gerrit.wikimedia.org/r/493034

Change 493037 merged by Reedy:
[mediawiki/core@REL1_30] Return the page_id in list=iwbacklinks as an int rather than string

https://gerrit.wikimedia.org/r/493037

Change 493041 merged by Reedy:
[mediawiki/core@REL1_27] Return the page_id in list=iwbacklinks as an int rather than string

https://gerrit.wikimedia.org/r/493041

Change 493038 merged by Reedy:
[mediawiki/core@REL1_30] Return the page_id in list=langbacklinks as an int

https://gerrit.wikimedia.org/r/493038

Change 493042 merged by Reedy:
[mediawiki/core@REL1_27] Return the page_id in list=langbacklinks as an int

https://gerrit.wikimedia.org/r/493042