Page MenuHomePhabricator
Create Task
Maniphest T218090

Extension:FlaggedRevs can't control which revision is used on API action=parse calls.
Open, LowPublicFeature
Actions

Description

If an extension like Extension:FlaggedRevs is used, it should ideally be able to consistently force stable revisions everywhere, but the action=parse API currently doesn't respect extensions like this.

Steps to Reproduce:

  • Install a wiki with Extension:FlaggedRevs installed
  • Edit a page but keep it unreviewed
  • Do an API call via action=parse (/api.php?action=parse&page=<Title>&prop=text&wrapoutputclass=)

Actual Results:
The unreviewed most recent version of the page is used for parsing.

Expected Results:
The stable version as defined by Extension:FlaggedRevs should be used for parsing.

Related Objects

Event Timeline

FO-nTTaX created this task.Mar 12 2019, 12:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 12 2019, 12:32 PM
Aklapper removed a project: MediaWiki-General.Mar 12 2019, 2:07 PM

Removing MediaWiki-General as it's not the task of MediaWiki core itself to check for the existence of all potential extensions and adjust default core behavior. It would be up to FlaggedRevs to provide additional API that fulfills this wish.

Aklapper changed the subtype of this task from "Bug Report" to "Feature Request".Mar 12 2019, 2:16 PM
FO-nTTaX added a comment.Mar 12 2019, 2:23 PM

The reason why I added Core is that there is no way to hook into this behaviour for all I could see in the relevant file, but I trust you to know what kind of tags are relevant.

Aklapper added a comment.Mar 12 2019, 2:30 PM

I don't think that this should hook into (=change) existing behavior of action=parse. It would create inconsistent behavior between installations with FlaggedRevs and without FlaggedRevs installed, plus it would also require changing API documentation (which could work locally but would create confusion if someone checked the online documentation and wondered why they correctly followed the online docs but their installation behaves totally differently).

Wugapodes moved this task from Backlog to Feature requests on the MediaWiki-extensions-FlaggedRevs board.Mar 16 2021, 9:10 PM
Wugapodes triaged this task as Low priority.Mar 16 2021, 9:40 PM
Wugapodes subscribed.

Having action=parse return something other than the most recent revision is a bad idea. There might be value in creating a flag that allows the user to signal their preference for stable revisions like parsestable=true, but I agree with Aklapper that this should not be the default behavior.

Wugapodes mentioned this in T209936: Content of unaccepted pending revisions show up in RESTBase APIs.Mar 16 2021, 10:17 PM
cscott mentioned this in T301372: Core Page REST API should follow redirects.Jun 17 2022, 1:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL