Page MenuHomePhabricator

pagegenerators_tests.EventStreamsPageGeneratorTestCase fails in test_RC_pagegenerator_result
Closed, ResolvedPublic

Description

In Appveyor we have the following failure:

======================================================================
ERROR: test_RC_pagegenerator_result (tests.pagegenerators_tests.EventStreamsPageGeneratorTestCase)
Test RC pagegenerator.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "c:\projects\pywikibot-g4xqx\tests\pagegenerators_tests.py", line 1577, in test_RC_pagegenerator_result
    entries = list(pagegenerator)
  File "c:\projects\pywikibot-g4xqx\pywikibot\pagegenerators.py", line 2664, in LiveRCPageGenerator
    for entry in site_rc_listener(site, total=total):
  File "c:\projects\pywikibot-g4xqx\pywikibot\comms\eventstreams.py", line 300, in __iter__
    event = next(self.source)
  File "build\bdist.win32\egg\sseclient.py", line 90, in __next__
    next_chunk = next(self.resp_iterator)
  File "build\bdist.win32\egg\sseclient.py", line 67, in generate
    chunk = self.resp.raw._fp.fp.read1(self.chunk_size)
AttributeError: '_fileobject' object has no attribute 'read1'
----------------------------------------------------------------------
Ran 1765 tests in 752.765s

https://ci.appveyor.com/project/Ladsgroup/pywikibot-g4xqx/builds/23291054/job/tgp7kqyss3n30mmh?fullLog=true

Seems this is from upstream because sseclient had a change in 0.0.23 recently

Event Timeline

Xqt triaged this task as High priority.Mar 22 2019, 6:56 PM
Xqt added subscribers: Ottomata, Dalba, xSavitar.

Change 498452 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [tests] Don't use sseclient 0.0.23

https://gerrit.wikimedia.org/r/498452

Change 498452 merged by jenkins-bot:
[pywikibot/core@master] [tests] Don't use sseclient 0.0.23

https://gerrit.wikimedia.org/r/498452

@Xqt, if the issue is resolved, you can resolve this ticket, thanks!

Xqt claimed this task.

Resolved by preventing sseclient 0.0.23 being loaded