Maniphest T219095

Standardize basestring/StringTypes behavior
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Dvorapa
	Mar 24 2019, 1:16 PM

Description

There is a huge amount of basestring and StringTypes definitions across various places. Move them from scripts and libraries to pywikibot/tools/__init__.py and import them in place only

Details

	Subject	Repo	Branch	Lines +/-
	[bugfix] Fix basestring/StringTypes across scripts	pywikibot/core	master	+150 -203

Customize query in gerrit

Event Timeline

Dvorapa created this task.Mar 24 2019, 1:16 PM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptMar 24 2019, 1:16 PM

Change 498727 had a related patch set uploaded (by Dvorapa; owner: Dvorapa):
[pywikibot/core@master] [bugfix] Fix basestring/StringTypes across scripts

https://gerrit.wikimedia.org/r/498727

gerritbot added a project: Patch-For-Review.Mar 24 2019, 6:42 PM

Change 498727 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] Fix basestring/StringTypes across scripts

https://gerrit.wikimedia.org/r/498727

Dvorapa closed this task as Resolved.Mar 24 2019, 8:11 PM

Dvorapa claimed this task.

Dvorapa triaged this task as Medium priority.

Additional comments are given at https://gerrit.wikimedia.org/r/c/pywikibot/core/+/498727

Maintenance_bot removed a project: Patch-For-Review.Aug 23 2020, 9:10 AM