I noticed it in wmf.23. Ace stopped highlighting functions, keywords etc., basically anything other than variables. I see the culprit is https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/481836/. More specifically, the regex for variables is matched first, and even if Ace doesn't find a corresponding token, it won't try the next rule. Thinking of a fix right now.
Description
Description
Details
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Restore highlighting of all keywords, functions, etc. | mediawiki/extensions/AbuseFilter | master | +10 -5 |
Event Timeline
Comment Actions
Change 499996 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Restore highlighting of all keywords, functions, etc.
Comment Actions
Change 499996 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Restore highlighting of all keywords, functions, etc.