Maniphest T219593

Language constructs other than variables aren't highlighted anymore
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Daimona
	Mar 29 2019, 8:57 AM

Description

I noticed it in wmf.23. Ace stopped highlighting functions, keywords etc., basically anything other than variables. I see the culprit is https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/481836/. More specifically, the regex for variables is matched first, and even if Ace doesn't find a corresponding token, it won't try the next rule. Thinking of a fix right now.

Details

	Subject	Repo	Branch	Lines +/-
	Restore highlighting of all keywords, functions, etc.	mediawiki/extensions/AbuseFilter	master	+10 -5

Customize query in gerrit

Event Timeline

Daimona created this task.Mar 29 2019, 8:57 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 29 2019, 8:57 AM

Change 499996 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Restore highlighting of all keywords, functions, etc.

https://gerrit.wikimedia.org/r/499996

gerritbot added a project: Patch-For-Review.Mar 29 2019, 9:44 AM

Daimona claimed this task.Mar 29 2019, 9:45 AM

Change 499996 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Restore highlighting of all keywords, functions, etc.

https://gerrit.wikimedia.org/r/499996

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.24; 2019-04-02).Mar 31 2019, 4:01 PM

Daimona closed this task as Resolved.Mar 31 2019, 4:02 PM

Daimona removed a project: Patch-For-Review.

Language constructs other than variables aren't highlighted anymoreClosed, ResolvedPublicActions

Description

Details

Event Timeline

Language constructs other than variables aren't highlighted anymore
Closed, ResolvedPublic
Actions