When trying to deploy a cherry-pick for CirrusSearch, we've encountered this error:
[16:30:20] <MaxSem> 23:27:19 sync-file failed: <CalledProcessError> Command 'find -O2 '/srv/mediawiki-staging/php-1.34.0-wmf.1/extensions/CirrusSearch' -not -type d -name '*.php' -not -name 'autoload_static.php' -or -name '*.inc' | xargs -n1 -P30 -exec php -l >/dev/null 2>&1' returned non-zero exit status 125
Further investigation showed that the culprit is:
$ php -l /srv/mediawiki-staging/php-1.34.0-wmf.1/extensions/CirrusSearch/tests/phan/stubs/intl.php [Thu Apr 25 00:17:58 2019] [hphp] [140517:7f12eff713c0:0:000001] [] Lost parent, LightProcess exiting [Thu Apr 25 00:17:58 2019] [hphp] [140518:7f12eff713c0:0:000001] [] Lost parent, LightProcess exiting Aborted (core dumped)
So hhvm breaks when trying to read intl.php file which defines class Transliterator. This seems to happen in all hhvm versions past 3.11.1: https://3v4l.org/Dq206
PHP 7 is fine with this file. This doesn't seem to be new since previous branches have the same file and produce the same error.
We need to look into how to handle this - either remove this specific check or ask hhvm for a fix or find some other solution.