message in the edit form
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ciencia_Al_Poder
	May 6 2019, 9:20 AM

Description

When an edit triggers the captcha, it displays an "error" message at the top of the captcha, that prints literally, <div class="error">$1</div>

I can see the message being print in the ReCaptchaNoCaptcha.php file on line 165:

$msg = new RawMessage( '<div class="error">$1</div>', [ $msg ] );

Details

Subject	Repo	Branch	Lines +/-
Do not ignore message parameters	mediawiki/extensions/ConfirmEdit	REL1_33	+2 -2
Do not ignore message parameters	mediawiki/extensions/ConfirmEdit	master	+2 -2
Do not ignore message parameters	mediawiki/extensions/ConfirmEdit	REL1_32	+2 -2

Customize query in gerrit

Event Timeline

Ciencia_Al_Poder created this task.May 6 2019, 9:20 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 6 2019, 9:20 AM

Working on it :)

Change 511087 had a related patch set uploaded (by Florianschmidtwelzow; owner: Florianschmidtwelzow):
[mediawiki/extensions/ConfirmEdit@master] Do not ignore message parameters

https://gerrit.wikimedia.org/r/511087

gerritbot added a project: Patch-For-Review.May 18 2019, 7:27 PM

Change 511087 merged by jenkins-bot:
[mediawiki/extensions/ConfirmEdit@master] Do not ignore message parameters

https://gerrit.wikimedia.org/r/511087

Florian closed this task as Resolved.May 19 2019, 8:45 AM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.6; 2019-05-21).May 19 2019, 9:00 AM

Change 511136 had a related patch set uploaded (by Martineznovo; owner: Florianschmidtwelzow):
[mediawiki/extensions/ConfirmEdit@REL1_32] Do not ignore message parameters

https://gerrit.wikimedia.org/r/511136

Change 511136 merged by jenkins-bot:
[mediawiki/extensions/ConfirmEdit@REL1_32] Do not ignore message parameters

https://gerrit.wikimedia.org/r/511136

Ciencia_Al_Poder removed a project: Patch-For-Review.May 19 2019, 10:23 AM

Aklapper added a project: Wikimania-Hackathon-2019.May 19 2019, 10:42 AM

Aklapper edited projects, added Wikimedia-Hackathon-2019; removed Wikimania-Hackathon-2019.May 20 2019, 1:40 PM

Change 511982 had a related patch set uploaded (by Martineznovo; owner: Florianschmidtwelzow):
[mediawiki/extensions/ConfirmEdit@REL1_33] Do not ignore message parameters

https://gerrit.wikimedia.org/r/511982

gerritbot added a project: Patch-For-Review.May 22 2019, 8:22 PM

Change 511982 merged by jenkins-bot:
[mediawiki/extensions/ConfirmEdit@REL1_33] Do not ignore message parameters

https://gerrit.wikimedia.org/r/511982

Aklapper moved this task from Backlog to Projects on the Wikimedia-Hackathon-2019 board.May 24 2019, 10:55 AM

ReCaptchaNoCaptcha displaying a <div class="error">$1</div> message in the edit formClosed, ResolvedPublicActions

Description

Details

Event Timeline

ReCaptchaNoCaptcha displaying a <div class="error">$1</div> message in the edit form
Closed, ResolvedPublic
Actions