Remove leading PMC from PMC field
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Mvolz
	May 21 2019, 1:11 PM

Description

There are two PMCs in PMC field from this url from the citoid rest service: https://www.ncbi.nlm.nih.gov/pmc/articles/PMC4241502/

	Subject	Repo	Branch	Lines +/-
	Remove PMC prefix in PMCID field	mediawiki/services/citoid	master	+11 -11

Mentioned In: T157152: Visual Editor adds erroneous text "PMC" to citation template pmc= parameter

Mvolz added a subscriber: Antigng.

The cause of this problem has been identified. Given that

const rePMCID = new RegExp('\\bPMC\\d{7}\\b');

If this condition is satisfied, keyValue[1].trim() must have already contained a 'PMC' prefix. Thus the next line

content.PMCID = `PMC${keyValue[1].trim()}`;

would result in a duplication of the 'PMC' prefix.

Change 513767 had a related patch set uploaded (by Mvolz; owner: Mvolz):
[mediawiki/services/citoid@master] Remove PMC prefix in PMCID field

Change 513767 merged by jenkins-bot:
[mediawiki/services/citoid@master] Remove PMC prefix in PMCID field

Mvolz closed this task as Resolved.Jun 10 2019, 1:23 PM

Mvolz triaged this task as Medium priority.

Mvolz reopened this task as Open.Jun 11 2019, 9:14 AM

Mvolz moved this task from Service to Waiting on Deploy on the Citoid board.

Mvolz closed this task as Resolved.Jul 13 2019, 9:08 AM