Installer.php defines a constant and will throw an error if called multiple times.
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Valeryan_M
	May 24 2019, 12:56 PM

Description

overrideConfig() is a public static function in includes/installer/installer.php and it defines a constant without first checking if it is already defined. This function can be called more than once if you are doing some custom install task or setting up wiki farms, etc...

the fix is simple:

if ( !defined( 'MW_NO_SESSION_HANDLER' ) ) {
    define( 'MW_NO_SESSION_HANDLER', 1 );
}

Details

	Subject	Repo	Branch	Lines +/-
	installer: Add a defined check to overrideConfig method	mediawiki/core	master	+3 -1

Customize query in gerrit

Event Timeline

Valeryan_M created this task.May 24 2019, 12:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 24 2019, 12:56 PM

Valeryan_M updated the task description. (Show Details)May 24 2019, 12:57 PM

Hi @Valeryan_M, can you make a patch or can someone else pick this up? I'll be happy to review the patch :)

Contributio subscribed.May 26 2019, 9:14 PM

Contributio unsubscribed.

Contributio subscribed.

@D3r1ck01 Sure, I'll get that put together.

Change 512966 had a related patch set uploaded (by ValeryanM; owner: ValeryanM):
[mediawiki/core@master] Adding a defined check to overrideConfig method

https://gerrit.wikimedia.org/r/512966

gerritbot added a project: Patch-For-Review.May 28 2019, 7:37 PM

Change 512966 merged by jenkins-bot:
[mediawiki/core@master] installer: Add a defined check to overrideConfig method

https://gerrit.wikimedia.org/r/512966

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.15; 2019-07-23).Jul 20 2019, 7:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jul 20 2019, 7:10 AM

RazeSoldier closed this task as Resolved.Jul 21 2019, 2:51 AM

RazeSoldier assigned this task to Valeryan_M.