Page MenuHomePhabricator
Create Task
Maniphest T224884

Rate limit requests to cache_upload
Closed, ResolvedPublic
Actions

Description

Currently we do implement VCL-based rate limiting for requests to cache_text and, in the case of cache_upload, only for specific source IPs and maps. We need to implement global rate limiting for cache_upload.

Details

SubjectRepoBranchLines +/-
varnish: bump general upload rate limitsoperations/puppetproduction+2 -2
varnish: cache_upload miss/pass rate limitoperations/puppetproduction+13 -4
Customize query in gerrit

Event Timeline

• ema created this task.Jun 3 2019, 2:20 PM
Restricted Application added a project: SRE. · View Herald TranscriptJun 3 2019, 2:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• ema triaged this task as Medium priority.Jun 3 2019, 2:20 PM
Paladox subscribed.Jun 3 2019, 2:23 PM
• ema moved this task from Backlog to Caching on the Traffic board.Jun 3 2019, 3:09 PM
gerritbot added a comment.Jun 3 2019, 3:17 PM

Change 513596 had a related patch set uploaded (by Ema; owner: John Bond):
[operations/puppet@production] varnish: cache_upload global cache miss rate limit

https://gerrit.wikimedia.org/r/513596

gerritbot added a project: Patch-For-Review.Jun 3 2019, 3:17 PM
gerritbot added a comment.Jun 3 2019, 3:52 PM

Change 514041 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] lvm_support: Increase timeout

https://gerrit.wikimedia.org/r/514041

gerritbot added a comment.Jun 6 2019, 11:45 AM

Change 513596 merged by Ema:
[operations/puppet@production] varnish: cache_upload miss/pass rate limit

https://gerrit.wikimedia.org/r/513596

• ema closed this task as Resolved.Jun 6 2019, 3:25 PM
gerritbot added a comment.Jun 7 2019, 10:14 AM

Change 515027 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] varnish: bump general upload rate limits

https://gerrit.wikimedia.org/r/515027

gerritbot added a comment.Jun 7 2019, 10:22 AM

Change 515027 merged by Ema:
[operations/puppet@production] varnish: bump general upload rate limits

https://gerrit.wikimedia.org/r/515027

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits