Page MenuHomePhabricator

Cancel link from edit page always returns to current version instead of version being edited
Closed, ResolvedPublic

Description

Author: rwoodworth

Description:
How to reproduce:

  1. Go to any revision history.
  2. Click the datestamp on an old version.
  3. Click the edit tab.
  4. Scroll down and click the cancel button.

What happens: The current version of the page is displayed.
What should happen: The old version of the page (same as step 2) is displayed.
Workaround: use the back button in the browser, instead of the cancel button.

(Seems so obvious that someone should have posted it already. But I searched several times and didn't see it.)

Many thanks,


Version: 1.15.x
Severity: minor

Details

Reference
bz20517

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:54 PM
bzimport set Reference to bz20517.
bzimport added a subscriber: Unknown Object (MLST).
brion added a comment.Sep 14 2009, 5:15 PM

Clarified summary.

IAlex added a comment.Sep 16 2009, 8:43 PM

Fixed in r56441.

rwoodworth wrote:

Wow! Thank you, thank you.

brion added a comment.Sep 29 2009, 9:52 PM

Fix is insufficient; try for instance previewing the edit -- now the cancel link shows no oldid parameter.

ayg wrote:

Why do we even have a cancel button? Removing it seems like the easiest fix; it's clutter. We may as well have a back button on every page . . . that's what the browser UI is for.

IAlex added a comment.Feb 5 2010, 3:01 PM

Corrected in r62027.