Page MenuHomePhabricator
Create Task
Maniphest T226718

Add option to filter by file extension/img_minor_mime in requeueTranscodes.php
Closed, ResolvedPublic
Actions

Description

Noticed from T226713: Run cleanupTranscodes.php for current midi files... There's no way to filter by a file specific type to just enqueue those types in requeueTranscodes.php...

We have a useful index... So as long as we pass in img_major_mime too in some way, we're already setting img_media_type to AUDIO or VIDEO

CREATE INDEX /*i*/img_media_mime ON /*_*/image (img_media_type,img_major_mime,img_minor_mime);

Probably better than a LIKE on img_name?

Details

SubjectRepoBranchLines +/-
requeueTranscodes: Allow filtering by major and minor mimemediawiki/extensions/TimedMediaHandlerwmf/1.34.0-wmf.11+8 -0
requeueTranscodes: Allow filtering by major and minor mimemediawiki/extensions/TimedMediaHandlermaster+8 -0
Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.Jun 27 2019, 2:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 27 2019, 2:36 PM
Reedy updated the task description. (Show Details)Jun 27 2019, 2:37 PM
Reedy renamed this task from Add option to filter by file extension/img_minor_mime to Add option to filter by file extension/img_minor_mime in requeueTranscodes.php.Jun 27 2019, 2:45 PM
Reedy updated the task description. (Show Details)
gerritbot added a comment.Jun 27 2019, 10:18 PM

Change 519540 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/TimedMediaHandler@master] Allow filtering by major and minor mime

https://gerrit.wikimedia.org/r/519540

gerritbot added a project: Patch-For-Review.Jun 27 2019, 10:18 PM
gerritbot added a comment.Jun 28 2019, 1:50 AM

Change 519540 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] requeueTranscodes: Allow filtering by major and minor mime

https://gerrit.wikimedia.org/r/519540

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.13; 2019-07-09).Jun 28 2019, 2:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 28 2019, 2:10 AM
Reedy closed this task as Resolved.Jun 28 2019, 9:45 AM
Reedy claimed this task.
Reedy mentioned this in T226713: Run cleanupTranscodes.php for current midi files.
gerritbot added a comment.Jun 28 2019, 10:02 AM

Change 519608 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/TimedMediaHandler@wmf/1.34.0-wmf.11] requeueTranscodes: Allow filtering by major and minor mime

https://gerrit.wikimedia.org/r/519608

gerritbot added a project: Patch-For-Review.Jun 28 2019, 10:02 AM
gerritbot added a comment.Jun 28 2019, 10:17 AM

Change 519608 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@wmf/1.34.0-wmf.11] requeueTranscodes: Allow filtering by major and minor mime

https://gerrit.wikimedia.org/r/519608

Reedy removed a project: Patch-For-Review.Jun 28 2019, 10:19 AM
ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.11; 2019-06-26); removed MW-1.34-notes (1.34.0-wmf.13; 2019-07-09).Jun 28 2019, 11:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits