Page MenuHomePhabricator
Create Task
Maniphest T228273

If TRACKER_MANUAL_LINK is None, do not show any help link
Closed, ResolvedPublic
Actions

Description

Task summary

If TRACKER_MANUAL_LINK is set to None, help link (see attached image) is still shown.

Student is expected to send a patch for wikimedia-cz/tracker repository, hosted at Wikimedia Gerrit. When claiming task on GCI website, student should claim a respective Phabricator task as well.

Materials

image.png (459×1 px, 82 KB)

Materials

Details

SubjectRepoBranchLines +/-
If TRACKER_MANUAL_LINK is None, do not show any help linkwikimedia-cz/trackermaster+6 -2
Customize query in gerrit

Event Timeline

Urbanecm created this task.Jul 17 2019, 1:00 PM
Urbanecm moved this task from Inbox to Ready (PM's approval not needed) on the WMCZ-Tracker board.Jul 29 2019, 8:19 PM
Urbanecm added a project: User-Urbanecm.Aug 25 2019, 11:57 PM
Urbanecm moved this task from Backlog to GCI on the User-Urbanecm board.Aug 25 2019, 11:59 PM
Urbanecm moved this task from Ready (PM's approval not needed) to GCI on the WMCZ-Tracker board.Aug 26 2019, 5:08 PM
Urbanecm updated the task description. (Show Details)Oct 12 2019, 4:56 PM
Urbanecm added a project: Google-Code-in-2019.Oct 29 2019, 9:03 PM

Imported as https://codein.withgoogle.com/tasks/4736968592719872/.

Urbanecm moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2019 board.Oct 29 2019, 9:03 PM
Urbanecm removed a project: User-Urbanecm.Nov 24 2019, 7:36 PM
Safan41 claimed this task.Dec 4 2019, 2:04 AM
Safan41 subscribed.
gerritbot added a comment.Dec 4 2019, 3:28 AM

Change 554405 had a related patch set uploaded (by Safan41; owner: Safan41):
[wikimedia-cz/tracker@master] Ref T228273

https://gerrit.wikimedia.org/r/554405

gerritbot added a project: Patch-For-Review.Dec 4 2019, 3:28 AM
Safan41 added a comment.Dec 4 2019, 3:30 AM

I believe this does it.

gerritbot added a comment.Dec 4 2019, 9:45 PM

Change 554405 had a related patch set uploaded (by Safan41; owner: Safan41):
[wikimedia-cz/tracker@master] If TRACKER_MANUAL_LINK is None, do not show any help link

https://gerrit.wikimedia.org/r/554405

gerritbot added a comment.Dec 5 2019, 7:34 AM

Change 554405 merged by jenkins-bot:
[wikimedia-cz/tracker@master] If TRACKER_MANUAL_LINK is None, do not show any help link

https://gerrit.wikimedia.org/r/554405

Urbanecm closed this task as Resolved.Dec 5 2019, 7:36 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL