Page MenuHomePhabricator

AbuseFilter: "Lines added in edit" (added_lines) shows old lines, not added; same oddity for "unified diff" (edit_diff) and "Lines removed in edit" (removed_lines)
Closed, ResolvedPublic

Description

Author: Wiki.Melancholie

Description:


Version: unspecified
Severity: enhancement
URL: http://als.wikipedia.org/w/index.php?title=Special:AbuseLog&details=616&uselang=en

Details

Reference
bz20851

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 10:52 PM
bzimport added projects: AbuseFilter, TestMe.
bzimport set Reference to bz20851.
bzimport added a subscriber: Unknown Object (MLST).

Wiki.Melancholie wrote:

Sorry, pressed enter accidentally.

AbuseFilter: "Lines added in edit" (added_lines) shows old lines, not added on the specific edit.

Sometimes the whole page content is shown, sometimes on or two lines before and after the added line(s).
It's the same oddity for "Unified diff of changes made by edit" (edit_diff) and for "Lines removed in edit" (removed_lines).

Wiki.Melancholie wrote:

Examples:

This happens since the last big code update.

beau wrote:

*** This bug has been marked as a duplicate of bug 19716 ***

anderson.kleiner wrote:

This problem has been seen by me a couple of days ago. As I'm not sure if this bug is really a duplicate from bug 19716, I guess I should report it again:

Please, compare the value of added_lines and removed_lines variables with the actual diff on this case:

What I've found particulary odd was that this problem occured only with some edits, and mostly with bots edits, although at time the code wasn't filtering by user group (I've even added a user group condition, thinking at first this could be the problem, though it not seems the case now).

If it is actually a duplicate of bug 19716, I'm anticipating my apologies.

beau wrote:

*** This bug has been marked as a duplicate of bug 20310 ***