Page MenuHomePhabricator
Create Task
Maniphest T229574

Make logging warning or info of not finding entity for revision configurable
Closed, DeclinedPublic
Actions

Description

In https://gerrit.wikimedia.org/r/#/q/I21413771b90466de4ae45a8b160d4c4f1f341f93,
we stopped logging a warning for when an entity isn't found for a given
revision.

We want to keep logging a warning for Wikidata, but let other users of Wikibase turn that warning off through configuration in case they have more expected and frequent use-cases hitting this path. See T229482: PHP Warning: Wikibase\Lib\Store\Sql\WikiPageEntityRevisionLookup::getEntityRevision: Entity not loaded for such case we faced on Commons.

Related Objects

Event Timeline

• alaa_wmde created this task.Aug 1 2019, 12:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 1 2019, 12:17 PM
gerritbot added a comment.Aug 1 2019, 12:17 PM

Change 527090 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan):
[mediawiki/extensions/Wikibase@master] Make logging warning or info of not finding entity for revision configurable

https://gerrit.wikimedia.org/r/527090

gerritbot added a project: Patch-For-Review.Aug 1 2019, 12:17 PM
• alaa_wmde moved this task from Peer Review to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 7 2019, 8:00 AM
• alaa_wmde added a comment.Aug 7 2019, 8:03 AM

This is now failing because Elastic is using that class internally and need to be updated so that it instantiate with the new argument, merge that into master, then run Wikibase's CI again. Though I will look first into comment https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/527015/7/lib/includes/Store/Sql/WikiPageEntityRevisionLookup.php#148 to figure out what to do next. It can be that we don't need the warning after all.

• alaa_wmde removed • alaa_wmde as the assignee of this task.Aug 7 2019, 8:03 AM
• alaa_wmde closed this task as Declined.Oct 1 2019, 2:42 PM

We don't want to do this. We will probably flip back to warning (or equivalent) and handle MediaInfo special case in MediaInfo extension iteself (after coordianation)

• alaa_wmde mentioned this in T234336: Set error report for missing entity in main slot to warning.Oct 1 2019, 3:08 PM
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Oct 27 2019, 11:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL