Page MenuHomePhabricator

Make logging warning or info of not finding entity for revision configurable
Closed, DeclinedPublic

Description

In https://gerrit.wikimedia.org/r/#/q/I21413771b90466de4ae45a8b160d4c4f1f341f93,
we stopped logging a warning for when an entity isn't found for a given
revision.

We want to keep logging a warning for Wikidata, but let other users of Wikibase turn that warning off through configuration in case they have more expected and frequent use-cases hitting this path. See T229482: PHP Warning: Wikibase\Lib\Store\Sql\WikiPageEntityRevisionLookup::getEntityRevision: Entity not loaded for such case we faced on Commons.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 1 2019, 12:17 PM

Change 527090 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan):
[mediawiki/extensions/Wikibase@master] Make logging warning or info of not finding entity for revision configurable

https://gerrit.wikimedia.org/r/527090

This is now failing because Elastic is using that class internally and need to be updated so that it instantiate with the new argument, merge that into master, then run Wikibase's CI again. Though I will look first into comment https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/527015/7/lib/includes/Store/Sql/WikiPageEntityRevisionLookup.php#148 to figure out what to do next. It can be that we don't need the warning after all.

alaa_wmde removed alaa_wmde as the assignee of this task.Aug 7 2019, 8:03 AM
alaa_wmde closed this task as Declined.Tue, Oct 1, 2:42 PM

We don't want to do this. We will probably flip back to warning (or equivalent) and handle MediaInfo special case in MediaInfo extension iteself (after coordianation)