Page MenuHomePhabricator

#dbctl: generate hostsByName section as well
Closed, ResolvedPublic

Description

The instance schema already includes host_ip and port fields we don't do anything with (but are accurate).

We should use them to generate the hostsByName sections currently in the PHP files as well. This will likely also involve creating a bunch of instance objects that aren't pooled anywhere / aren't in the usual sectionLoads location; we'll need to include them in the output hostsByName config regardless.

Event Timeline

Change 531973 had a related patch set uploaded (by CDanis; owner: CDanis):
[operations/software/conftool@master] dbctl: initial support for hostsByName

https://gerrit.wikimedia.org/r/531973

Change 531973 merged by jenkins-bot:
[operations/software/conftool@master] dbctl: initial support for hostsByName

https://gerrit.wikimedia.org/r/531973

Change 559136 had a related patch set uploaded (by CDanis; owner: CDanis):
[operations/mediawiki-config@master] dbctl: use hostsByName from etcd

https://gerrit.wikimedia.org/r/559136

Change 559136 merged by CDanis:
[operations/mediawiki-config@master] dbctl: use hostsByName from etcd

https://gerrit.wikimedia.org/r/559136

Mentioned in SAL (#wikimedia-operations) [2019-12-18T17:58:58Z] <cdanis@deploy1001> Synchronized wmf-config/CommonSettings.php: use hostsByName from etcd 96df9c004 T229676 T240991 (duration: 01m 01s)

Change 559154 had a related patch set uploaded (by CDanis; owner: CDanis):
[operations/mediawiki-config@master] remove dbctl-obsoleted hostsByName entries 🔧

https://gerrit.wikimedia.org/r/559154

Change 559154 merged by jenkins-bot:
[operations/mediawiki-config@master] remove dbctl-obsoleted hostsByName entries 🔧

https://gerrit.wikimedia.org/r/559154

Mentioned in SAL (#wikimedia-operations) [2019-12-18T18:13:58Z] <cdanis@deploy1001> Synchronized wmf-config/db-codfw.php: remove dbctl-obsoleted hostsByName entries 🔧 7d20965f5 T240991 T229676 (duration: 01m 01s)

Mentioned in SAL (#wikimedia-operations) [2019-12-18T18:15:53Z] <cdanis@deploy1001> Synchronized wmf-config/db-eqiad.php: remove dbctl-obsoleted hostsByName entries 🔧 7d20965f5 T240991 T229676 (duration: 01m 01s)

CDanis claimed this task.