Page MenuHomePhabricator

Change SVN post-commit hooks to not block while notifications go out
Closed, DeclinedPublic

Description

Our post-commit hooks run several notifications, at least:

  • email w/ diff to mediawiki-cvs
  • CIA ping
  • mediawiki.org CodeReview ping

These are run with & to background them, but I don't think the whole script actually exits until they're done; this leads to 'svn commit' taking several seconds longer to return than it should, which is frustrating to devs.

The notifications should either be fully backgrounded without blocking the parent shell script, or they should be run from a separate process after the revision is added to a job queue of some kind.


Version: unspecified
Severity: enhancement

Details

Reference
bz21211

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:49 PM
bzimport set Reference to bz21211.

Taking this from Brion, I'm more likely to do it than he is :D

Who cares? We're moving to git anyway ;-)