Figure out right way to add CORS header to docker-registry.tools.wmflabs.org
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	bd808
	Sep 5 2019, 6:18 PM

Description

In https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/528617/ I tried to add a CORS header, but the docker-registry service ended up not starting with the error message:

Sep 05 18:09:28 tools-docker-registry-03 docker-registry[650]: configuration error: error parsing /etc/docker/registry/config.yml: yaml: unmarshal errors:

The generated YAML looked like:

http:
  addr: 127.0.0.1:5000
  headers:
    Access-Control-Allow-Origin: "['*']"
storage:
  cache:
    blobdescriptor: inmemory
  filesystem:
    rootdirectory: "/srv/registry"
version: 0.1

Details

	Subject	Repo	Branch	Lines +/-
	toolforge: Add more CORS headers to docker registry	operations/puppet	production	+2 -0
	toolforge: Add CORS header to docker registry	operations/puppet	production	+5 -0

Customize query in gerrit

Event Timeline

bd808 created this task.Sep 5 2019, 6:18 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 5 2019, 6:18 PM

bd808 triaged this task as Medium priority.Sep 5 2019, 6:18 PM

Mentioned in SAL (#wikimedia-cloud) [2019-09-05T21:02:18Z] <bd808> Enabled Puppet on tools-docker-registry-03 and forced puppet run (T232135)

bd808 moved this task from Inbox to Doing on the cloud-services-team (Kanban) board.Sep 6 2019, 2:39 PM

Change 558220 had a related patch set uploaded (by BryanDavis; owner: Bryan Davis):
[operations/puppet@production] toolforge: Add CORS header to docker registry

https://gerrit.wikimedia.org/r/558220

gerritbot added a project: Patch-For-Review.Dec 16 2019, 9:34 PM

Change 558220 merged by Alexandros Kosiaris:
[operations/puppet@production] toolforge: Add CORS header to docker registry

https://gerrit.wikimedia.org/r/558220

Maintenance_bot removed a project: Patch-For-Review.Dec 19 2019, 6:10 PM

bd808 closed this task as Resolved.Dec 19 2019, 9:01 PM

Change 936797 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[operations/puppet@production] toolforge: Add more CORS headers to docker registry

https://gerrit.wikimedia.org/r/936797

Restricted Application added a project: User-bd808. · View Herald TranscriptJul 10 2023, 11:07 PM

gerritbot added a project: Patch-For-Review.Jul 10 2023, 11:07 PM

Change 936797 merged by Alexandros Kosiaris: