Page MenuHomePhabricator

Cannot undo text changes when going back after preview
Closed, ResolvedPublic

Description

We used to be able to undo text changes with the CTRL+Z shortcut (Edit>Undo). This is after clicking the show preview button and going back to the previous page.
This is not possible anymore.

Steps to reproduce :

  1. Open an article to edit (by example http://en.wikipedia.org/w/index.php?title=Water_cycle&action=edit)
  2. Modify something in the text.
  3. Click "Show preview"
  4. Go back to the http://en.wikipedia.org/w/index.php?title=Water_cycle&action=edit page (with the browser back button).
  5. Try undo the changes from 2. with CTRL+Z or Edit>Undo.

Results :
Cannot undo.

Expected results :
Be able to undo.

Reproduced with Firefox 3.5, Opera 9.63, IE 6 (sic).

Now if I adblock http://en.wikipedia.org/w/extensions/UsabilityInitiative/js/js2.combined.min.js?8 it works again.

Setting the severity to major because it can induce a loss of work.


Version: unspecified
Severity: major

Details

Reference
bz21219

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:50 PM
bzimport set Reference to bz21219.

Previously, this bug was only reproduceable when the user choose to try the Acai beta. More precisely, it was linked to the new toolbar (disabling it in the preferences "fixed" the bug).

A quick fix would be to avoid sending the UsabilityInitiative related files to the users who didn't choose to try the beta (as it was the case in the beginning).

(In reply to comment #1)

Previously, this bug was only reproduceable when the user choose to try the
Acai beta. More precisely, it was linked to the new toolbar (disabling it in
the preferences "fixed" the bug).

A quick fix would be to avoid sending the UsabilityInitiative related files to
the users who didn't choose to try the beta (as it was the case in the
beginning).

This regression seems to be caused by the ClickTracking extension, I'll look at it later today.

(In reply to comment #2)

This regression seems to be caused by the ClickTracking extension, I'll look at
it later today.

Fixed this particular regression in r57978 (not live yet).

This has clearly been resolved, and is actually no longer relevant given we don't use a textarea at all anymore.

I can still reproduce (by enabling the "enhanced editing toolbar" in the Editing preferences), so I guess it isn't live yet?

(In reply to comment #4)

This has clearly been resolved, and is actually no longer relevant given we
don't use a textarea at all anymore.

That actually doesn't make it irrelevant, because browser support for Ctrl+Z in iframes isn't perfect either. The only thing that really resolves this is the side-by-side preview feature because it allows you to stay on the same page while previewing. Leaving as FIXED because we do have a solution for this in trunk (side-by-side preview).

(In reply to comment #5)

I can still reproduce (by enabling the "enhanced editing toolbar" in the
Editing preferences), so I guess it isn't live yet?

No, not yet.

Reopening as obviously it isn't fixed, though the changes are live.

*** Bug 24508 has been marked as a duplicate of this bug. ***