Page MenuHomePhabricator

Clean-up and consolidate `.errorbox` and `.error` styles in MobileFrontend and MinervaNeue
Open, Needs TriagePublic

Description

Currently there are several instances of .errorbox scattered in

  • MobileFrontend/resources/mobile.messageBox.styles/messageBox.less
  • MobileFrontend/resources/mobile.special.styles/common.less
  • MinervaNeue/resources/skins.minerva.base.styles/ui.less
  • MinervaNeue/skinStyles/mediawiki.special.userlogin.common.styles/minerva.less

and somewhat related .error treatment, that actually should be an error box in

  • MobileFrontend/resources/mobile.talk.overlays/talk.less

It seems unnecessarily complex to have those separated.

Also, .error should be used for inline error messages and .errorbox for error block messages and adhere to the standard treatment represented in OOUI's MessageBox.

Details

Related Gerrit Patches:
mediawiki/extensions/MobileFrontend : masterUnify foreground color and restructure 'messageBox' rules

Event Timeline

Volker_E created this task.Sep 7 2019, 2:52 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 7 2019, 2:52 AM
Volker_E updated the task description. (Show Details)Sep 7 2019, 3:29 AM

Change 534900 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/MobileFrontend@master] Restructure 'messageBox' rules

https://gerrit.wikimedia.org/r/534900

Change 534900 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Unify foreground color and restructure 'messageBox' rules

https://gerrit.wikimedia.org/r/534900

Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptFri, Jan 17, 10:40 PM