Page MenuHomePhabricator
Create Task
Maniphest T232238

Clean-up and consolidate `.errorbox` and `.error` styles in MobileFrontend and MinervaNeue
Closed, ResolvedPublic
Actions

Description

Currently there are several instances of .errorbox scattered in

  • MobileFrontend/resources/mobile.messageBox.styles/messageBox.less
  • MobileFrontend/resources/mobile.special.styles/common.less
  • MinervaNeue/resources/skins.minerva.base.styles/ui.less
  • MinervaNeue/skinStyles/mediawiki.special.userlogin.common.styles/minerva.less

and somewhat related .error treatment, that actually should be an error box in

  • MobileFrontend/resources/mobile.talk.overlays/talk.less

It seems unnecessarily complex to have those separated.

Also, .error should be used for inline error messages and .errorbox for error block messages and adhere to the standard treatment represented in OOUI's MessageBox.

Details

SubjectRepoBranchLines +/-
Use `errorbox` for cookie saving error messagemediawiki/extensions/MobileFrontendmaster+1 -1
Unify foreground color and restructure 'messageBox' rulesmediawiki/extensions/MobileFrontendmaster+18 -19
Customize query in gerrit

Event Timeline

Volker_E created this task.Sep 7 2019, 2:52 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 7 2019, 2:52 AM
Volker_E updated the task description. (Show Details)Sep 7 2019, 3:29 AM
gerritbot added a comment.Sep 7 2019, 3:36 AM

Change 534900 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/MobileFrontend@master] Restructure 'messageBox' rules

https://gerrit.wikimedia.org/r/534900

gerritbot added a project: Patch-For-Review.Sep 7 2019, 3:36 AM
Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Sep 9 2019, 8:31 PM
gerritbot added a comment.Sep 9 2019, 10:56 PM

Change 534900 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Unify foreground color and restructure 'messageBox' rules

https://gerrit.wikimedia.org/r/534900

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.22; 2019-09-10).Sep 9 2019, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 9 2019, 11:10 PM
Jdlrobson moved this task from Backlog to Blocked on Discussion on the MinervaNeue board.Jan 17 2020, 10:40 PM
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptJan 17 2020, 10:40 PM
Volker_E added a comment.Feb 19 2020, 8:36 PM

Instance of wrongly applied error inline class, this needs to be errorbox:

image.png (922×852 px, 91 KB)

gerritbot added a comment.Feb 19 2020, 8:43 PM

Change 573374 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/MobileFrontend@master] Use errorbox for cookie saving error message

https://gerrit.wikimedia.org/r/573374

gerritbot added a project: Patch-For-Review.Feb 19 2020, 8:43 PM
Volker_E added a comment.Feb 19 2020, 8:43 PM

With patch above:

image.png (742×848 px, 66 KB)

gerritbot added a comment.Feb 19 2020, 9:00 PM

Change 573374 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Use errorbox for cookie saving error message

https://gerrit.wikimedia.org/r/573374

Maintenance_bot removed a project: Patch-For-Review.Feb 19 2020, 9:10 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Feb 19 2020, 10:00 PM
Jdlrobson added a project: User-Jdlrobson.Apr 17 2020, 7:06 PM

What's remaining on this one @Volker_E ? Anything?

Jdlrobson closed this task as Resolved.Jun 9 2020, 11:34 PM
Jdlrobson claimed this task.

I'm assuming this can be resolved.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits