Page MenuHomePhabricator

mediawiki/tools/release: make-deploy-notes/uploadChangelog.php should not use escapeshellarg or shell_exec
Closed, DeclinedPublic

Description

mediawiki/mediawiki-codesniffer complains about make-deploy-notes/uploadChangelog.php using escapeshellarg and shell_exec. Code should be refactored to please codesniffer.

Event Timeline

They are forbidden since https://gerrit.wikimedia.org/r/c/mediawiki/tools/codesniffer/+/423030 which suggests to use MediaWiki execution framework instead (aka wfShellExec). It might be ported to use wikimedia/shellbox instead, but is most probably not worth it.