Page MenuHomePhabricator

Infinite recursion in Thread::loadAllData()
Closed, ResolvedPublic


Eugene reported on IRC that posting to LiquidThreads, e.g. using "reply", was totally broken and left the ajax spinner going forever. He indicated that this had been occurring since some time earlier today.

Investigation showed that this was a segfault in api.php?action=threadaction&threadaction=reply&..., with a backtrace showing an infinite recursion of Thread::loadAllData(). A trivial call to loadAllData() from eval.php did not lead to infinite recursion, so it's likely that the problem only occurs after local data is updated.

I've rolled back the latest merge from trunk (r58164) pending a permanent fix.

Version: unspecified
Severity: blocker



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:57 PM
bzimport set Reference to bz21319.

Fix committed in r58473 and deployed to WMF wikis.