Page MenuHomePhabricator
Create Task
Maniphest T233362

Error and warning messages in HTMLForm/VForm should be boxed messages
Closed, ResolvedPublic
Actions

Description

The output, which doesn't seem to be used as inline messages (any more?) is presented as box above the form:

image.png (456×326 px, 26 KB)

Those should carry errorbox/warningbox classes, not error/warning which are meant to be reserved for inline messages.

Details

SubjectRepoBranchLines +/-
Messages collected above the form are meant to live as boxed messagesmediawiki/coremaster+6 -25
Customize query in gerrit

Event Timeline

Volker_E created this task.Sep 19 2019, 8:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 19 2019, 8:33 PM
gerritbot added a comment.Sep 19 2019, 8:47 PM

Change 538105 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Messages collected above the form are meant to live as boxed messages

https://gerrit.wikimedia.org/r/538105

gerritbot added a project: Patch-For-Review.Sep 19 2019, 8:47 PM
Volker_E added a project: UI-Standardization-Kanban.Sep 19 2019, 11:49 PM
Restricted Application added a project: UI-Standardization. · View Herald TranscriptSep 19 2019, 11:49 PM
Aklapper edited projects, added MediaWiki-HTMLForm; removed MediaWiki-General.Sep 20 2019, 9:20 AM
matmarex subscribed.Sep 20 2019, 11:05 PM
gerritbot added a comment.Sep 20 2019, 11:33 PM

Change 538105 merged by jenkins-bot:
[mediawiki/core@master] Messages collected above the form are meant to live as boxed messages

https://gerrit.wikimedia.org/r/538105

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.24; 2019-09-24).Sep 21 2019, 12:01 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 21 2019, 12:10 AM
Volker_E closed this task as Resolved.Sep 21 2019, 1:57 AM
Volker_E claimed this task.
Volker_E triaged this task as Medium priority.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL