set and set_var should have the same treatment as assignment expression
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Nullzero
	Nov 4 2019, 3:24 AM

Description

Following should be disallowed:

set('true', 1)

Note that this is always checkable, because the first argument to set and set_var is required to be a literal string, not arbitrary expression.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Forbid assignments where the LHS is a built-in identifier	mediawiki/extensions/AbuseFilter	master	+49 -8

Customize query in gerrit

Event Timeline

Nullzero created this task.Nov 4 2019, 3:24 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 4 2019, 3:24 AM

I think that, right now, code like true := 1 only fails for a coincidence, not because it's validated. So IMHO the patch for this one should go on top of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/547871/.

Change 547871 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Forbid assignments where the LHS is a built-in identifier

https://gerrit.wikimedia.org/r/547871

gerritbot added a project: Patch-For-Review.Nov 4 2019, 5:57 PM

Daimona claimed this task.Nov 4 2019, 5:58 PM

Change 547871 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Forbid assignments where the LHS is a built-in identifier

https://gerrit.wikimedia.org/r/547871

Daimona closed this task as Resolved.Dec 3 2019, 7:21 PM

Daimona removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.10; 2019-12-10).Dec 3 2019, 8:00 PM

set and set_var should have the same treatment as assignment expressionClosed, ResolvedPublicActions

Description

Details

Event Timeline

set and set_var should have the same treatment as assignment expression
Closed, ResolvedPublic
Actions