tests: Add explicit return type void to setUp()
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Pwirth
	Nov 5 2019, 11:28 AM

Description

since the upgrade to phpcs 28 in core the tests fail:
PHP Fatal error: Declaration of NSFileRepo\Tests\NamespaceListTest::setUp() must be compatible with MediaWikiLangTestCase::setUp(): void in /workspace/src/extensions/NSFileRepo/tests/phpunit/NamespaceListTest.php on line 104

Event Timeline

Pwirth created this task.Nov 5 2019, 11:28 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 5 2019, 11:28 AM

Change 548708 had a related patch set uploaded (by Pwirth; owner: Pwirth):
[mediawiki/extensions/NSFileRepo@master] Add compatibility with MediaWikiLangTestCase::setUp. T237381

https://gerrit.wikimedia.org/r/548708

gerritbot added a project: Patch-For-Review.Nov 5 2019, 11:28 AM

Change 548708 merged by jenkins-bot:
[mediawiki/extensions/NSFileRepo@master] Add compatibility with MediaWikiLangTestCase::setUp. T237381

https://gerrit.wikimedia.org/r/548708

Maintenance_bot removed a project: Patch-For-Review.Nov 5 2019, 4:10 PM

Pwirth closed this task as Resolved.Nov 6 2019, 8:16 AM

tests: Add explicit return type void to setUp()Closed, ResolvedPublicActions

Description

Event Timeline

tests: Add explicit return type void to setUp()
Closed, ResolvedPublic
Actions