Page MenuHomePhabricator
Create Task
Maniphest T237435

LocalisationUpdate's GET request of HttpFetcher::fetchFile() should follow redirects
Closed, ResolvedPublic
Actions

Description

HttpFetcher::fetchFile() tries to fetch from, say, https://raw.github.com/Wikimedia/mediawiki-extensions-Abusefilter/master/i18n/de.json is redirected to https://raw.githubusercontent.com/Wikimedia/mediawiki-extensions-Abusefilter/master/i18n/de.json. But it uses \Http::get() function without the option [ 'followRedirects' => true ] returns only empty string "" and always ends up with the result massage "Found no new translations".

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Allow to follow redirect for fetching filesLens0021mediawiki/extensions/LocalisationUpdatemaster+1 -1
Customize query in gerrit

Event Timeline

Lens0021 created this task.Nov 5 2019, 4:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 5 2019, 4:41 PM
gerritbot added a comment.Nov 5 2019, 4:46 PM

Change 548785 had a related patch set uploaded (by Lens0021; owner: Lens0021):
[mediawiki/extensions/LocalisationUpdate@master] Allow to follow redirect for fetching files

https://gerrit.wikimedia.org/r/548785

gerritbot added a project: Patch-For-Review.Nov 5 2019, 4:46 PM
Lens0021 updated the task description. (Show Details)Nov 5 2019, 4:52 PM
Lens0021 renamed this task from Http::get of HttpFetcher::fetchFile() should follow redirects to GET request of HttpFetcher::fetchFile() should follow redirects.Nov 5 2019, 4:55 PM
gerritbot added a comment.Nov 5 2019, 6:25 PM

Change 548785 merged by jenkins-bot:
[mediawiki/extensions/LocalisationUpdate@master] Allow to follow redirect for fetching files

https://gerrit.wikimedia.org/r/548785

Jdforrester-WMF renamed this task from GET request of HttpFetcher::fetchFile() should follow redirects to LocalisationUpdate's GET request of HttpFetcher::fetchFile() should follow redirects.Nov 5 2019, 6:57 PM
Jdforrester-WMF closed this task as Resolved.
Jdforrester-WMF assigned this task to Lens0021.
Jdforrester-WMF removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 5 2019, 7:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits