Page MenuHomePhabricator

VE inserted templates don't have have the "i" property in the parts array
Closed, ResolvedPublic

Description

https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2019.11.20/parsoid-php?id=AW6GUml4KWrIH1QRWMDX&_g=h@1251ff0

Porting bug: Parsoid-PHP probably assumes that the "i" (template index in data-parsoid) property is always set in the parts array of data-mw. But, VE doesn't insert this.

Example output:

<span typeof="mw:Transclusion" data-mw='{"parts":[{"template":{"target":{"href":"Template:Quote","wt":"Quote"},"params":{"text":{"wt":"something"},"sign":{"wt":"some"},"source":{"wt":""}}}}]}'></span>

Event Timeline

ssastry triaged this task as Medium priority.Nov 20 2019, 5:15 AM
ssastry created this task.

Change 551951 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] html2wt: Handle missing property in data-mw template parts

https://gerrit.wikimedia.org/r/551951

Change 551951 merged by jenkins-bot:
[mediawiki/services/parsoid@master] html2wt: Handle missing property in data-mw template parts

https://gerrit.wikimedia.org/r/551951