Page MenuHomePhabricator

Server 500 on trying to modify application status from INVALID to anything else
Closed, ResolvedPublic

Description

Trying to modify the status of an invalid application results in a server 500 error, since we exclude apps with the status INVALID when using the normal objects.get/filter(). Handle this error gracefully (return the coordinator back to the app with an error message) and write tests to cover this use case.

Event Timeline

Restricted Application added subscribers: Sadads, Aklapper. · View Herald TranscriptNov 30 2019, 7:56 AM
AVasanth_WMF triaged this task as Medium priority.Nov 30 2019, 7:57 AM
AVasanth_WMF updated the task description. (Show Details)
AVasanth_WMF moved this task from Incoming tasks to Open tasks on the Library-Card-Platform board.
lalit97 added subscribers: Samwalton9, lalit97.EditedFeb 29 2020, 8:26 PM

Hello @Samwalton9 I am able to reproduce this error, and I think I can handle this as described. Can I work on this one?

Absolutely - I don't have time to provide further guidance on the steps required beforehand, but I'd be happy to answer questions or give feedback as you give it a go :)

Yes that will work for me :D, Will give an update on this soon.

lalit97 claimed this task.Mon, Mar 2, 7:47 PM
Samwalton9 closed this task as Resolved.Tue, Mar 10, 10:47 AM
Samwalton9 moved this task from Open tasks to Done on the Library-Card-Platform board.