Server 500 on trying to modify application status from INVALID to anything else
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• AVasanth_WMF
	Nov 30 2019, 7:56 AM

Description

Trying to modify the status of an invalid application results in a server 500 error, since we exclude apps with the status INVALID when using the normal objects.get/filter(). Handle this error gracefully (return the coordinator back to the app with an error message) and write tests to cover this use case.

Event Timeline

• AVasanth_WMF created this task.Nov 30 2019, 7:56 AM

Restricted Application added subscribers: Sadads, Aklapper. · View Herald TranscriptNov 30 2019, 7:56 AM

• AVasanth_WMF triaged this task as Medium priority.Nov 30 2019, 7:57 AM

• AVasanth_WMF updated the task description. (Show Details)

• AVasanth_WMF moved this task from Incoming tasks to Open tasks on the Library-Card-Platform board.

Nikkimaria added a parent task: T240153: Address project technical debt.Dec 8 2019, 9:41 PM

Samwalton9-WMF removed a parent task: T240153: Address project technical debt.Feb 14 2020, 1:12 PM

Hello @Samwalton9 I am able to reproduce this error, and I think I can handle this as described. Can I work on this one?

Absolutely - I don't have time to provide further guidance on the steps required beforehand, but I'd be happy to answer questions or give feedback as you give it a go :)

Yes that will work for me :D, Will give an update on this soon.

lalit97 claimed this task.Mar 2 2020, 7:47 PM

Hello @Samwalton9 I've raised a PR for this at https://github.com/WikipediaLibrary/TWLight/pull/429

Samwalton9-WMF closed this task as Resolved.Mar 10 2020, 10:47 AM

Samwalton9-WMF moved this task from Open tasks to Done on the Library-Card-Platform board.

Server 500 on trying to modify application status from INVALID to anything elseClosed, ResolvedPublicActions

Description

Event Timeline

Server 500 on trying to modify application status from INVALID to anything else
Closed, ResolvedPublic
Actions