Page MenuHomePhabricator

Samwalton9 (Sam Walton)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Mar 13 2015, 1:47 PM (254 w, 5 d)
Availability
Available
IRC Nick
Samwalton9
LDAP User
Unknown
MediaWiki User
Samwalton9 [ Global Accounts ]

Program Officer at The Wikipedia Library.

Also User:Samwalton9 (WMF).

Recent Activity

Yesterday

Samwalton9 added a comment to T239598: Allow users to customise data granularity for edits over time graph.

I agree with Aditya - I think it's best to just provide the user with the choice in all cases rather than try to make guesses about what will or won't look good. Just provide all options all the time :)

Tue, Jan 28, 6:53 PM · Google-Code-in-2019, Hashtags
Samwalton9 updated subscribers of T242196: Reword 'I accept' button to 'Submit' on Terms of Use page.

Yes - I wanted to pull the changes to review them but didn't find time last week. @AVasanth_WMF could you review? It's a fairly straightforward code change, but from a quick review it wasn't clear to me if the contributor might have inadvertently changed the css class for the button too.

Tue, Jan 28, 6:52 PM · good first task, Library-Card-Platform

Sun, Jan 26

Samwalton9 closed T226648: Fix server error on /users/ when site has no coordinators as Resolved.
Sun, Jan 26, 1:11 PM · good first task, Library-Card-Platform

Fri, Jan 24

Samwalton9 added a comment to T226648: Fix server error on /users/ when site has no coordinators.

Oh, looks like this might have been fixed in https://github.com/WikipediaLibrary/TWLight/commit/bbed99a8014f0900c92fc8e14256b9292f5481a0

Fri, Jan 24, 5:16 PM · good first task, Library-Card-Platform
Samwalton9 added a comment to T226648: Fix server error on /users/ when site has no coordinators.

Very curious! That suggests to me that we didn't understand the problem correctly. I actually can't reproduce it locally. I wonder if we inadvertently fixed this somewhere else.

Fri, Jan 24, 5:13 PM · good first task, Library-Card-Platform
Samwalton9 added a comment to T218857: Add more links to activity feed.

Hi @Sanyam.wikime! Sorry to see you're getting those issues. It looks like the database container might not have come up correctly. If you do docker ps what is the result?

Fri, Jan 24, 3:41 PM · good first task, Library-Card-Platform

Thu, Jan 23

Samwalton9 closed T215273: Allow coordinators to see unavailable partners they are assigned to, a subtask of T240168: Improve UX relating to unavailable partners, as Resolved.
Thu, Jan 23, 10:42 AM · Library-Card-Platform
Samwalton9 closed T215273: Allow coordinators to see unavailable partners they are assigned to as Resolved.
Thu, Jan 23, 10:42 AM · good first task, Library-Card-Platform
Samwalton9 added a comment to T226648: Fix server error on /users/ when site has no coordinators.

For the test case, I went through users/test.py but found it intimidating. I have no experience with test cases :\ Please guide me how I can complete this task.

Thu, Jan 23, 10:38 AM · good first task, Library-Card-Platform
Samwalton9 added a comment to T242130: Resize buttons on results page.

https://github.com/WikipediaLibrary/hashtags/pull/53

Thu, Jan 23, 10:24 AM · Hashtags
Samwalton9 moved T242130: Resize buttons on results page from Incoming to Doing on the Hashtags board.
Thu, Jan 23, 10:24 AM · Hashtags

Tue, Jan 21

Samwalton9 closed T228384: Allow users to filter bot edits as Resolved.
Tue, Jan 21, 4:32 PM · Google-Code-in-2019, good first task, Wikilink-Tool

Fri, Jan 17

Samwalton9 updated the task description for T226648: Fix server error on /users/ when site has no coordinators.
Fri, Jan 17, 12:19 PM · good first task, Library-Card-Platform
Samwalton9 added a project to T242740: Hide applications to Bundle partners on My Applications page: good first task.
Fri, Jan 17, 12:16 PM · good first task, Library-Card-Platform
Samwalton9 closed T240598: Send content of comments in emails as Resolved.
Fri, Jan 17, 10:25 AM · Library-Card-Platform

Thu, Jan 16

Samwalton9 moved T240598: Send content of comments in emails from Open tasks to Doing on the Library-Card-Platform board.
Thu, Jan 16, 10:48 AM · Library-Card-Platform
Samwalton9 added a comment to T240598: Send content of comments in emails.

Looks good to me! Please go ahead and make a PR :)

Thu, Jan 16, 10:48 AM · Library-Card-Platform

Wed, Jan 15

Samwalton9 added a comment to T240598: Send content of comments in emails.

This is looking really great!

Wed, Jan 15, 3:24 PM · Library-Card-Platform

Tue, Jan 14

Samwalton9 triaged T242742: When a partner is switched to Library Bundle access method, set all open applications to Invalid as Medium priority.
Tue, Jan 14, 2:08 PM · Library-Card-Platform
Samwalton9 added a subtask for T235262: Implement Library Bundle functionality: T242742: When a partner is switched to Library Bundle access method, set all open applications to Invalid.
Tue, Jan 14, 2:07 PM · Library-Card-Platform-Proxy
Samwalton9 added a parent task for T242742: When a partner is switched to Library Bundle access method, set all open applications to Invalid: T235262: Implement Library Bundle functionality.
Tue, Jan 14, 2:07 PM · Library-Card-Platform
Samwalton9 renamed T242740: Hide applications to Bundle partners on My Applications page from Hide applications to Bundle partners on My Applications to Hide applications to Bundle partners on My Applications page.
Tue, Jan 14, 2:07 PM · good first task, Library-Card-Platform
Samwalton9 created T242742: When a partner is switched to Library Bundle access method, set all open applications to Invalid.
Tue, Jan 14, 12:42 PM · Library-Card-Platform
Samwalton9 created T242740: Hide applications to Bundle partners on My Applications page.
Tue, Jan 14, 12:40 PM · good first task, Library-Card-Platform
Samwalton9 updated the task description for T230522: Redesign browse page.
Tue, Jan 14, 12:39 PM · Library-Card-Platform-Proxy
Samwalton9 updated the task description for T230522: Redesign browse page.
Tue, Jan 14, 12:39 PM · Library-Card-Platform-Proxy
Samwalton9 reopened T230522: Redesign browse page, a subtask of T209830: Design interface updates for proxy/bundle implementation, as Open.
Tue, Jan 14, 12:29 PM · Library-Card-Platform-Proxy
Samwalton9 reopened T230522: Redesign browse page as "Open".
Tue, Jan 14, 12:29 PM · Library-Card-Platform-Proxy

Mon, Jan 13

Samwalton9 added a comment to T240598: Send content of comments in emails.

I'll try to lay this task out a bit more thoroughly:

Mon, Jan 13, 12:24 PM · Library-Card-Platform

Thu, Jan 9

Samwalton9 moved T242196: Reword 'I accept' button to 'Submit' on Terms of Use page from Open tasks to Done on the Library-Card-Platform board.

https://github.com/WikipediaLibrary/TWLight/pull/387

Thu, Jan 9, 10:46 AM · good first task, Library-Card-Platform

Wed, Jan 8

Samwalton9 added a comment to T242196: Reword 'I accept' button to 'Submit' on Terms of Use page.

I'm not sure if it's too small of a task for GCI, but if not then sure!

Wed, Jan 8, 9:25 AM · good first task, Library-Card-Platform
Samwalton9 triaged T242196: Reword 'I accept' button to 'Submit' on Terms of Use page as Low priority.
Wed, Jan 8, 9:10 AM · good first task, Library-Card-Platform
Samwalton9 created T242196: Reword 'I accept' button to 'Submit' on Terms of Use page.
Wed, Jan 8, 9:10 AM · good first task, Library-Card-Platform

Tue, Jan 7

Samwalton9 added a comment to T240598: Send content of comments in emails.

The email itself already exists, with a subject line. We just want to modify the variables (linked above) and the templates (the ones which start comment_notification_ in https://github.com/WikipediaLibrary/TWLight/tree/master/TWLight/emails/templates/emails).

Tue, Jan 7, 1:26 PM · Library-Card-Platform

Mon, Jan 6

Samwalton9 triaged T241991: "Data too long for column 'link'" error as High priority.
Mon, Jan 6, 3:29 PM · Wikilink-Tool
Samwalton9 created T241991: "Data too long for column 'link'" error.
Mon, Jan 6, 3:29 PM · Wikilink-Tool
Samwalton9 updated the task description for T240598: Send content of comments in emails.
Mon, Jan 6, 2:10 PM · Library-Card-Platform
Samwalton9 moved T211418: Create Github Releases and pull info into platform from Planned to Stalled or blocked on the Library-Card-Platform board.
Mon, Jan 6, 2:08 PM · Library-Card-Platform
Samwalton9 moved T239031: "Collections" link is not intuitive to find or clear what it is from Open tasks to Planned on the Library-Card-Platform board.
Mon, Jan 6, 2:01 PM · Library-Card-Platform
Samwalton9 updated subscribers of T241985: Tool dykstats reports error "no web service" (due to Trusty migration).

@ErrantX appears to be the tool maintainer.

Mon, Jan 6, 1:58 PM · Tools
Samwalton9 moved T228384: Allow users to filter bot edits from Features to Doing on the Wikilink-Tool board.

https://github.com/WikipediaLibrary/externallinks/pull/32

Mon, Jan 6, 1:53 PM · Google-Code-in-2019, good first task, Wikilink-Tool
Samwalton9 closed T203163: Fix List Applications overlapping statistics for waitlisted partners with short description panels as Resolved.
Mon, Jan 6, 9:59 AM · good first task, Library-Card-Platform
Samwalton9 closed T203163: Fix List Applications overlapping statistics for waitlisted partners with short description panels, a subtask of T175564: Re-work partner page metrics, as Resolved.
Mon, Jan 6, 9:59 AM · Library-Card-Platform-Proxy
Samwalton9 raised the priority of T239505: When finding the latest application to renew, ignore denied applications from Medium to High.

This is causing a renewal problem for someone.

Mon, Jan 6, 9:46 AM · Library-Card-Platform
Samwalton9 renamed T239505: When finding the latest application to renew, ignore denied applications from Investigate what can be done when users want to apply (or renew?) again when their previous application was declined (`NOT_APPROVED`) to When finding the latest application to renew, ignore denied applications.
Mon, Jan 6, 9:46 AM · Library-Card-Platform

Dec 20 2019

Samwalton9 added a comment to T240124: Handle proxied links in mainspace.

Thanks for that - we'll keep this in mind :)

Dec 20 2019, 12:11 PM · Library-Card-Platform
Samwalton9 triaged T241219: Link event graph should be a bar chart as Medium priority.
Dec 20 2019, 10:00 AM · Wikilink-Tool
Samwalton9 triaged T241218: If there is no data for one month on the total links sheet, don't show 0 as Medium priority.
Dec 20 2019, 10:00 AM · Wikilink-Tool
Samwalton9 created T241219: Link event graph should be a bar chart.
Dec 20 2019, 10:00 AM · Wikilink-Tool
Samwalton9 created T241218: If there is no data for one month on the total links sheet, don't show 0.
Dec 20 2019, 9:59 AM · Wikilink-Tool

Dec 19 2019

Samwalton9 added a comment to T239025: Reconfigure tagging.

Extend https://github.com/WikipediaLibrary/TWLight/blob/master/TWLight/resources/models.py#L41 for tag URL field.

Dec 19 2019, 5:27 PM · Library-Card-Platform
Samwalton9 closed T240429: Partner page server error when all applications have the same creation date as Resolved.
Dec 19 2019, 12:09 PM · Library-Card-Platform
Samwalton9 merged T239335: Link to Collections (research guides) page from Library Card platform into T239025: Reconfigure tagging.
Dec 19 2019, 12:09 PM · Library-Card-Platform
Samwalton9 merged task T239335: Link to Collections (research guides) page from Library Card platform into T239025: Reconfigure tagging.
Dec 19 2019, 12:08 PM · Library-Card-Platform

Dec 18 2019

Samwalton9 moved T215273: Allow coordinators to see unavailable partners they are assigned to from Open tasks to Doing on the Library-Card-Platform board.
Dec 18 2019, 10:39 AM · good first task, Library-Card-Platform
Samwalton9 closed T150012: Add a 'Back to partners' navigational button from partner signup pages, a subtask of T147434: Version 1.5: Beta fixes, as Resolved.
Dec 18 2019, 10:38 AM · Library-Card-Platform
Samwalton9 closed T150012: Add a 'Back to partners' navigational button from partner signup pages as Resolved.
Dec 18 2019, 10:38 AM · good first task, Library-Card-Platform
Samwalton9 closed T150012: Add a 'Back to partners' navigational button from partner signup pages, a subtask of T240150: Improve Library Card platform user experience, as Resolved.
Dec 18 2019, 10:38 AM · Library-Card-Platform

Dec 17 2019

Samwalton9 moved T150012: Add a 'Back to partners' navigational button from partner signup pages from Open tasks to Done on the Library-Card-Platform board.
Dec 17 2019, 1:00 PM · good first task, Library-Card-Platform

Dec 15 2019

Samwalton9 added a comment to T186706: Create a subpage for statistics and charts related to a hashtag search.

Hi @Shivanshu1086 - this project was for last year's Google Summer of Code and has been completed. You can find open tasks on the Hashtags board :)

Dec 15 2019, 3:57 PM · Outreach-Programs-Projects, Google-Summer-of-Code (2019), Hashtags

Dec 13 2019

Samwalton9 triaged T240673: Wikipedia Library program page doesn't load due to expensive db queries as High priority.
Dec 13 2019, 11:58 AM · Wikilink-Tool
Samwalton9 created T240673: Wikipedia Library program page doesn't load due to expensive db queries.
Dec 13 2019, 11:58 AM · Wikilink-Tool
Samwalton9 closed T233954: Load page content via ajax as Declined.

May not be the ideal solution.

Dec 13 2019, 11:56 AM · Wikilink-Tool
Samwalton9 placed T230523: Redesign partner pages up for grabs.
Dec 13 2019, 11:33 AM · Library-Card-Platform-Proxy

Dec 12 2019

Samwalton9 added a comment to T220087: Tag access code emails for translation.

That would be super appreciated, yes! :)

Dec 12 2019, 5:01 PM · good first task, Library-Card-Platform
Samwalton9 added a comment to T220087: Tag access code emails for translation.

Oh yep, wow that documentation really is bad. It should be docker-compose exec twlight /app/bin/virtualenv_migrate.sh

Dec 12 2019, 4:16 PM · good first task, Library-Card-Platform
Samwalton9 added a comment to T220087: Tag access code emails for translation.

Great! Our documentation really needs updating, so sorry that it's not totally useful.

Dec 12 2019, 3:42 PM · good first task, Library-Card-Platform
Samwalton9 added a comment to T220087: Tag access code emails for translation.

@Soumyaa1804 That looks like you already have a service running on port 3306, probably MySQL. If that service is currently running on your machine then the TWLight database can't also come up. Stopping your local service should fix this, via something like service mysql stop :)

Dec 12 2019, 12:07 PM · good first task, Library-Card-Platform

Dec 11 2019

Samwalton9 added a comment to T220087: Tag access code emails for translation.

@Soumyaa1804 If you'd like a suggestion for another task to take up, we have more tagged with good first task, which you can find listed at https://phabricator.wikimedia.org/project/board/2765/query/rCNFr9ipmEnt/ :)

Dec 11 2019, 3:18 PM · good first task, Library-Card-Platform
Samwalton9 claimed T240429: Partner page server error when all applications have the same creation date.

Luckily it turns out the culprit was unused code. Removed in https://github.com/WikipediaLibrary/TWLight/pull/375

Dec 11 2019, 11:18 AM · Library-Card-Platform
Samwalton9 triaged T240429: Partner page server error when all applications have the same creation date as High priority.
Dec 11 2019, 9:59 AM · Library-Card-Platform
Samwalton9 created T240429: Partner page server error when all applications have the same creation date.
Dec 11 2019, 9:58 AM · Library-Card-Platform

Dec 9 2019

Samwalton9 closed T199193: [3.7] Instant caching of linked resources via Internet Archive as Resolved.

As far as I know this is operational.

Dec 9 2019, 10:17 PM · Knowledge-Integrity, Epic, Internet-Archive
Samwalton9 closed T240126: MOU, a subtask of T240125: Integrate search and discovery interface, as Declined.
Dec 9 2019, 5:09 PM · Library-Card-Platform
Samwalton9 closed T240126: MOU as Declined.
Dec 9 2019, 5:09 PM · Library-Card-Platform
Samwalton9 closed T220087: Tag access code emails for translation as Resolved.

Thanks!

Dec 9 2019, 3:54 PM · good first task, Library-Card-Platform
Samwalton9 closed T220087: Tag access code emails for translation, a subtask of T240139: Improve the state of translations, as Resolved.
Dec 9 2019, 3:54 PM · Library-Card-Platform
Samwalton9 renamed T240169: Improve staff workflows from Staff workflow to Improve staff workflows.
Dec 9 2019, 10:39 AM · Library-Card-Platform
Samwalton9 renamed T240168: Improve UX relating to unavailable partners from Unavailable partners to Improve UX relating to unavailable partners.
Dec 9 2019, 10:39 AM · Library-Card-Platform
Samwalton9 renamed T240165: Improve Suggest page from Suggestions to Improve Suggest page.
Dec 9 2019, 10:39 AM · Library-Card-Platform
Samwalton9 renamed T240164: Provide better research support to editors from Research help to Provide better research support to editors.
Dec 9 2019, 10:38 AM · Library-Card-Platform
Samwalton9 renamed T240162: Improve analytics required for KPIs from KPIs to Improve analytics required for KPIs.
Dec 9 2019, 10:38 AM · Library-Card-Platform
Samwalton9 renamed T240160: Improve Library Card platform analytics from Analytics to Improve Library Card platform analytics.
Dec 9 2019, 10:37 AM · Library-Card-Platform
Samwalton9 renamed T240157: Fix broken django docs links from Django docs links to Fix broken django docs links.
Dec 9 2019, 10:37 AM · Library-Card-Platform
Samwalton9 renamed T240155: Improve test coverage from Testing sprint to Improve test coverage.
Dec 9 2019, 10:36 AM · Library-Card-Platform
Samwalton9 renamed T240152: Clarify licensing with respect to non-free images from Image licensing to Clarify licensing with respect to non-free images.
Dec 9 2019, 10:35 AM · Library-Card-Platform
Samwalton9 renamed T240150: Improve Library Card platform user experience from UX to Improve Library Card platform user experience.
Dec 9 2019, 10:35 AM · Library-Card-Platform
Samwalton9 lowered the priority of T191777: Overhaul and improve Library Card information security processes from High to Medium.
Dec 9 2019, 10:35 AM · Epic, Library-Card-Platform
Samwalton9 moved T191777: Overhaul and improve Library Card information security processes from Doing to Long-Term on the Library-Card-Platform board.
Dec 9 2019, 10:35 AM · Epic, Library-Card-Platform
Samwalton9 removed a subtask for T240148: Infosec: T200520: Log access to personal data.
Dec 9 2019, 10:34 AM · Library-Card-Platform
Samwalton9 removed a parent task for T200520: Log access to personal data: T240148: Infosec.
Dec 9 2019, 10:34 AM · Library-Card-Platform
Samwalton9 removed a subtask for T240148: Infosec: T191783: Notify users when their data is sent to partners.
Dec 9 2019, 10:34 AM · Library-Card-Platform
Samwalton9 removed a parent task for T191783: Notify users when their data is sent to partners: T240148: Infosec.
Dec 9 2019, 10:34 AM · Library-Card-Platform
Samwalton9 removed a subtask for T240148: Infosec: T157021: Consider some abuse mitigation measures.
Dec 9 2019, 10:34 AM · Library-Card-Platform
Samwalton9 added a subtask for T191777: Overhaul and improve Library Card information security processes: T157021: Consider some abuse mitigation measures.
Dec 9 2019, 10:34 AM · Epic, Library-Card-Platform
Samwalton9 edited parent tasks for T157021: Consider some abuse mitigation measures, added: T191777: Overhaul and improve Library Card information security processes; removed: T240148: Infosec.
Dec 9 2019, 10:34 AM · Library-Card-Platform-Proxy
Samwalton9 added a subtask for T191777: Overhaul and improve Library Card information security processes: T232115: Create a robots.txt.
Dec 9 2019, 10:34 AM · Epic, Library-Card-Platform
Samwalton9 removed a subtask for T240148: Infosec: T232115: Create a robots.txt.
Dec 9 2019, 10:34 AM · Library-Card-Platform
Samwalton9 edited parent tasks for T232115: Create a robots.txt, added: T191777: Overhaul and improve Library Card information security processes; removed: T240148: Infosec.
Dec 9 2019, 10:34 AM · Library-Card-Platform
Samwalton9 edited parent tasks for T239094: Record the dates of whenever a user agrees/disagrees to the Terms of Use, added: T191777: Overhaul and improve Library Card information security processes; removed: T240148: Infosec.
Dec 9 2019, 10:34 AM · Library-Card-Platform