Program Officer at The Wikipedia Library.
Also User:Samwalton9 (WMF).
I agree with Aditya - I think it's best to just provide the user with the choice in all cases rather than try to make guesses about what will or won't look good. Just provide all options all the time :)
Yes - I wanted to pull the changes to review them but didn't find time last week. @AVasanth_WMF could you review? It's a fairly straightforward code change, but from a quick review it wasn't clear to me if the contributor might have inadvertently changed the css class for the button too.
Oh, looks like this might have been fixed in https://github.com/WikipediaLibrary/TWLight/commit/bbed99a8014f0900c92fc8e14256b9292f5481a0
Very curious! That suggests to me that we didn't understand the problem correctly. I actually can't reproduce it locally. I wonder if we inadvertently fixed this somewhere else.
Hi @Sanyam.wikime! Sorry to see you're getting those issues. It looks like the database container might not have come up correctly. If you do docker ps what is the result?
For the test case, I went through users/test.py but found it intimidating. I have no experience with test cases :\ Please guide me how I can complete this task.
Looks good to me! Please go ahead and make a PR :)
This is looking really great!
I'll try to lay this task out a bit more thoroughly:
I'm not sure if it's too small of a task for GCI, but if not then sure!
The email itself already exists, with a subject line. We just want to modify the variables (linked above) and the templates (the ones which start comment_notification_ in https://github.com/WikipediaLibrary/TWLight/tree/master/TWLight/emails/templates/emails).
@ErrantX appears to be the tool maintainer.
This is causing a renewal problem for someone.
Thanks for that - we'll keep this in mind :)
Extend https://github.com/WikipediaLibrary/TWLight/blob/master/TWLight/resources/models.py#L41 for tag URL field.
May not be the ideal solution.
That would be super appreciated, yes! :)
Oh yep, wow that documentation really is bad. It should be docker-compose exec twlight /app/bin/virtualenv_migrate.sh
Great! Our documentation really needs updating, so sorry that it's not totally useful.
@Soumyaa1804 That looks like you already have a service running on port 3306, probably MySQL. If that service is currently running on your machine then the TWLight database can't also come up. Stopping your local service should fix this, via something like service mysql stop :)
@Soumyaa1804 If you'd like a suggestion for another task to take up, we have more tagged with good first task, which you can find listed at https://phabricator.wikimedia.org/project/board/2765/query/rCNFr9ipmEnt/ :)
Luckily it turns out the culprit was unused code. Removed in https://github.com/WikipediaLibrary/TWLight/pull/375
As far as I know this is operational.