Page MenuHomePhabricator

Samwalton9 (Sam Walton)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Mar 13 2015, 1:47 PM (219 w, 2 d)
Availability
Available
IRC Nick
Samwalton9
LDAP User
Unknown
MediaWiki User
Samwalton9 [ Global Accounts ]

Program Officer at The Wikipedia Library.

Also User:Samwalton9 (WMF).

Recent Activity

Mon, May 20

Samwalton9 updated subscribers of T179986: Investigate why current es2r daemon is randomly hanging.

@Ottomata Do you have any insight here - is this likely to be an issue on our end or something from the EventStream itself?

Mon, May 20, 8:50 AM · Wikimedia-Stream, Huggle
Samwalton9 added a comment to T214060: Collection script seemingly randomly stops working.

Looks like T179986 might be related. This potentially isn't a tool issue?

Mon, May 20, 8:50 AM · Hashtags
Samwalton9 placed T214060: Collection script seemingly randomly stops working up for grabs.
Mon, May 20, 8:49 AM · Hashtags
Samwalton9 added a comment to T179986: Investigate why current es2r daemon is randomly hanging.

I've been getting a similar issue at the Hashtags tool - my EventStream monitoring script, using sseclient, appears to hang and stop receiving data randomly every few days/weeks, but doesn't actually exit with any error.

Mon, May 20, 8:47 AM · Wikimedia-Stream, Huggle

Fri, May 17

Samwalton9 added a comment to T170383: Allow users to choose 6 or 12 month account lengths for proxy.

Jake suggested we offer 1/3/6/12 month drop-down options to avoid overloading the user with choice ("Should I ask for 10 months or 11 months?")

Fri, May 17, 3:00 PM · Library-Card-Platform-Proxy

Thu, May 16

Samwalton9 renamed T170383: Allow users to choose 6 or 12 month account lengths for proxy from Allow users to choose 6 or 12 month account lengths through authentication to Allow users to choose 6 or 12 month account lengths for proxy.
Thu, May 16, 12:48 PM · Library-Card-Platform-Proxy

Tue, May 14

Samwalton9 closed T222612: Recentchanges EventStream is sending historical data partially out of order as Resolved.

Worth being aware of, but not currently causing any problems for the tool.

Tue, May 14, 12:42 PM · Hashtags

Mon, May 13

Samwalton9 added a comment to T160292: Individual user authorization lifetime.

This is implemented, except for the piece that lets users know how long they have left. That will probably come in via the user page authorization list

Mon, May 13, 9:07 AM · Library-Card-Platform-Proxy

Fri, May 10

Samwalton9 updated the task description for T205531: Example data generation should create renewal requests with a range of request dates.
Fri, May 10, 2:35 PM · Library-Card-Platform
Samwalton9 added a comment to T206511: Give advance renewal notice for partners with fixed account lengths.

Code merged, but cron job for emails not running yet. Will be using django-cron when Docker work is complete.

Fri, May 10, 2:34 PM · Library-Card-Platform
Samwalton9 closed T213091: Re-add optional fixed account lengths as Resolved.
Fri, May 10, 2:34 PM · Library-Card-Platform
Samwalton9 closed T213091: Re-add optional fixed account lengths, a subtask of T206511: Give advance renewal notice for partners with fixed account lengths, as Resolved.
Fri, May 10, 2:34 PM · Library-Card-Platform
Samwalton9 closed T221849: Add test for account_length as Resolved.
Fri, May 10, 2:33 PM · Library-Card-Platform
Samwalton9 closed T220138: Automate sending single-use URLs to users as Resolved.
Fri, May 10, 2:31 PM · Library-Card-Platform
Samwalton9 added a comment to T175574: Administrators should be able to manually remove users from authentication whitelists.

At the moment this is basically implemented because admins can just delete the relevant authorization object. We should perhaps have an improved workflow for this, but this seems sufficient for the time being.

Fri, May 10, 10:28 AM · Library-Card-Platform-Proxy
Samwalton9 updated the task description for T175571: Provide links to partner entry points in obvious places.
Fri, May 10, 10:27 AM · Library-Card-Platform-Proxy
Samwalton9 closed T175569: When a user reaches the 6 or 12 month mark of their authentication access, they should automatically be removed from the whitelist as Resolved.

This is effectively already the case with authorizations since they have expiry dates. 'Removed from whitelist' means 'expiry date < today'. I don't think we need any other process to 'remove' them.

Fri, May 10, 10:25 AM · Library-Card-Platform-Proxy
Samwalton9 added a comment to T175557: Switching a partner from manual setup to authentication-based access should convert users with existing access to the whitelist.

This is probably going to need to be a manual process in almost all cases.

Fri, May 10, 10:24 AM · Library-Card-Platform-Proxy

Mon, May 6

Samwalton9 added a comment to T222612: Recentchanges EventStream is sending historical data partially out of order.

That makes a lot of sense - thanks for the explanation @Ottomata!

Mon, May 6, 4:00 PM · Hashtags
Samwalton9 renamed T222612: Recentchanges EventStream is sending historical data partially out of order from Recentchanges EventStream is sending future data out of order to Recentchanges EventStream is sending historical data partially out of order.
Mon, May 6, 2:12 PM · Hashtags
Samwalton9 renamed T222612: Recentchanges EventStream is sending historical data partially out of order from Event stream may not be being parsed in precise timestamp order to Recentchanges EventStream is sending future data out of order.
Mon, May 6, 2:10 PM · Hashtags
Samwalton9 added a comment to T222612: Recentchanges EventStream is sending historical data partially out of order.

So I've traced this back to the EventStream itself - from the query at https://stream.wikimedia.org/v2/stream/recentchange?since=2019-04-28 it can be seen that a bunch of events get thrown up from between the 28th and the 3rd May, before it picks up again from the correct place and sends events in the correct order.

Mon, May 6, 2:05 PM · Hashtags
Samwalton9 updated the task description for T222612: Recentchanges EventStream is sending historical data partially out of order.
Mon, May 6, 2:04 PM · Hashtags
Samwalton9 added a comment to T222612: Recentchanges EventStream is sending historical data partially out of order.
Mon, May 6, 2:00 PM · Hashtags
Samwalton9 added a comment to T222612: Recentchanges EventStream is sending historical data partially out of order.
Mon, May 6, 1:48 PM · Hashtags
Samwalton9 created T222612: Recentchanges EventStream is sending historical data partially out of order.
Mon, May 6, 1:39 PM · Hashtags

Fri, May 3

Samwalton9 added a comment to T169875: Investigate indexing of verified reference works in Wikisource.

An OAI-PMH feed would be ideal.

Fri, May 3, 8:57 AM · Library-Card-Platform-Discovery, Wikisource

Thu, May 2

Samwalton9 created T222363: Request creation of wikilink VPS project.
Thu, May 2, 1:22 PM · Cloud-VPS (Project-requests)

Apr 26 2019

Samwalton9 added a comment to T170384: Automatically waitlist and de-waitlist partners around their account limit.

One option for de-waitlisting could be checking periodically based on page load events. We could store the last date we de-waitlisted and if it isn't today -> run that task. In this way we've got the logic in app code rather than an external cron job. Alternatively, https://django-cron.readthedocs.io/en/latest/installation.html

Apr 26 2019, 10:10 AM · Library-Card-Platform-Proxy
Samwalton9 renamed T190431: Application comments not displaying on iOS from iOS display bug to Application comments not displaying on iOS.
Apr 26 2019, 9:55 AM · Library-Card-Platform
Samwalton9 moved T190431: Application comments not displaying on iOS from Major Bugs to Open tasks on the Library-Card-Platform board.
Apr 26 2019, 9:55 AM · Library-Card-Platform
Samwalton9 reopened T190431: Application comments not displaying on iOS as "Open".

Reported as being a problem again.

Apr 26 2019, 9:54 AM · Library-Card-Platform
Samwalton9 reopened T190431: Application comments not displaying on iOS, a subtask of T170977: Post-migration issues and priorities, as Open.
Apr 26 2019, 9:54 AM · Library-Card-Platform

Apr 25 2019

Samwalton9 claimed T221849: Add test for account_length.

https://github.com/WikipediaLibrary/TWLight/pull/261

Apr 25 2019, 2:45 PM · Library-Card-Platform
Samwalton9 created T221851: For Proxy partners, don't give the 'sent to partners' option on application evaluation.
Apr 25 2019, 1:04 PM · Library-Card-Platform-Proxy
Samwalton9 updated the task description for T170384: Automatically waitlist and de-waitlist partners around their account limit.
Apr 25 2019, 12:46 PM · Library-Card-Platform-Proxy
Samwalton9 renamed T170384: Automatically waitlist and de-waitlist partners around their account limit from Automatically waitlist partners that have reached the account limit to Automatically waitlist and de-waitlist partners around their account limit.
Apr 25 2019, 12:45 PM · Library-Card-Platform-Proxy
Samwalton9 created T221849: Add test for account_length.
Apr 25 2019, 12:29 PM · Library-Card-Platform

Apr 19 2019

Samwalton9 updated subscribers of T169875: Investigate indexing of verified reference works in Wikisource.

Looks like we could ingest OAI-PMH data into our search platform. That data was available from 2012 (T40498) but was disabled in 2017 because it had virtually no use (T129864). @Tpt - theoretically speaking how difficult would it be to re-enable this feature? We're not in a rush on this, just figuring out what it would take.

Apr 19 2019, 9:50 PM · Library-Card-Platform-Discovery, Wikisource

Apr 18 2019

Samwalton9 created T221397: Store page-links-change data in a database table and make available through a Special page.
Apr 18 2019, 6:19 PM · Internet-Archive, MediaWiki-extensions-WikimediaEvents, The-Wikipedia-Library
Samwalton9 added a project to T218898: Improve design and image metadata for error pages: good first bug.
Apr 18 2019, 4:30 PM · good first bug, Library-Card-Platform
Samwalton9 renamed T161170: List active authorizations on user pages from Users should have a clearer idea of which resources they have access to. to List active authorizations on user pages.
Apr 18 2019, 4:29 PM · Library-Card-Platform
Samwalton9 added a project to T193334: Add placeholder text to Review filters: good first bug.
Apr 18 2019, 4:25 PM · good first bug, Library-Card-Platform
Samwalton9 renamed T218849: Denote proposer and list upvoters on Suggest page from Visibility for proposers and up-voters for a resource-request to Denote proposer and list upvoters on Suggest page.
Apr 18 2019, 4:21 PM · good first bug, Library-Card-Platform
Samwalton9 triaged T211141: Notify all upvoters when suggested partner available as Low priority.
Apr 18 2019, 12:56 PM · Library-Card-Platform
Samwalton9 triaged T218853: Display partners who are not anymore in the platform, in a different manner in user-applications. as Normal priority.
Apr 18 2019, 12:56 PM · Library-Card-Platform
Samwalton9 closed T218850: Raise privileges for certain actions as Declined.

We'll revisit this if it becomes a more pressing issue.

Apr 18 2019, 12:55 PM · Library-Card-Platform
Samwalton9 triaged T218857: Add more links to activity feed as Low priority.
Apr 18 2019, 12:54 PM · good first bug, Library-Card-Platform
Samwalton9 renamed T218857: Add more links to activity feed from Tweaking the activity page to Add more links to activity feed.
Apr 18 2019, 12:53 PM · good first bug, Library-Card-Platform
Samwalton9 moved T218848: Improve UX for partnerships that end from Incoming tasks to Open tasks on the Library-Card-Platform board.
Apr 18 2019, 12:52 PM · Library-Card-Platform
Samwalton9 renamed T218848: Improve UX for partnerships that end from Non-availability of a resource to Improve UX for partnerships that end.
Apr 18 2019, 12:52 PM · Library-Card-Platform
Samwalton9 added a comment to T156807: Track number of available accounts per partner, and don't allow more than that to be distributed.

In terms of the workflow, we should still allow coordinators to view, comment, and set non-Approved/Sent statuses for applications, but if they attempt to Approve an application, we disallow that and post a message informing them we're out of accounts.

Apr 18 2019, 12:24 PM · Library-Card-Platform-Proxy
Samwalton9 added a comment to T170384: Automatically waitlist and de-waitlist partners around their account limit.
Apr 18 2019, 12:24 PM · Library-Card-Platform-Proxy

Apr 17 2019

Samwalton9 renamed T102055: Integrate EZProxy authentication into library card platform from Integrate EZProxy authentication (or other institutional proxy tool) into library card platform to Integrate EZProxy authentication into library card platform.
Apr 17 2019, 9:53 AM · Library-Card-Platform-Proxy
Samwalton9 closed T153431: Decide on editor requirements for creating a Library Bundle as Resolved.
Apr 17 2019, 9:53 AM · Library-Card-Platform-Proxy
Samwalton9 added a comment to T175564: For authentication-based partners, add information to partner pages on how many users are currently on the access whitelist.

We now show total approved users & accounts remaining, but this isn't the same as total authorized partners.

Apr 17 2019, 9:51 AM · Library-Card-Platform-Proxy
Samwalton9 closed T175560: Allow flagging of partners as manual setup or authentication-based access as Resolved.
Apr 17 2019, 9:50 AM · Library-Card-Platform-Proxy
Samwalton9 moved T220891: Reject with reason from Incoming tasks to Open tasks on the Library-Card-Platform board.
Apr 17 2019, 9:47 AM · Library-Card-Platform

Apr 15 2019

Samwalton9 assigned T216614: Review and improve project test coverage to ParthS007.

Codecov now active at https://codecov.io/gh/Samwalton9/hashtags!

Apr 15 2019, 11:03 AM · Hashtags

Apr 12 2019

Samwalton9 closed T152303: Create interface for TWL tracking & reporting of ExternalLinksChange data, a subtask of T102064: Create a tool to display and filter data from Schema:ExternalLinksChange, as Invalid.
Apr 12 2019, 1:24 PM · The-Wikipedia-Library
Samwalton9 closed T152303: Create interface for TWL tracking & reporting of ExternalLinksChange data as Invalid.

Reworking this plan elsewhere.

Apr 12 2019, 1:24 PM · The-Wikipedia-Library
Samwalton9 closed T152317: Allow tracking of TWL partner references through strings as Invalid.
Apr 12 2019, 1:24 PM · The-Wikipedia-Library
Samwalton9 closed T152317: Allow tracking of TWL partner references through strings, a subtask of T152303: Create interface for TWL tracking & reporting of ExternalLinksChange data, as Invalid.
Apr 12 2019, 1:24 PM · The-Wikipedia-Library
Samwalton9 closed T152323: Create administrator interface for adding new partners as Invalid.
Apr 12 2019, 1:24 PM · The-Wikipedia-Library
Samwalton9 closed T152323: Create administrator interface for adding new partners, a subtask of T152320: Ability to create pages per Wikipedia Library partner, as Invalid.
Apr 12 2019, 1:24 PM · The-Wikipedia-Library
Samwalton9 closed T152325: Partner pages should only show link changes for users with access to that partner as Invalid.
Apr 12 2019, 1:24 PM · The-Wikipedia-Library
Samwalton9 closed T152325: Partner pages should only show link changes for users with access to that partner, a subtask of T152320: Ability to create pages per Wikipedia Library partner, as Invalid.
Apr 12 2019, 1:24 PM · The-Wikipedia-Library
Samwalton9 closed T152324: Integration with the Library Card Platform for user data as Invalid.
Apr 12 2019, 1:24 PM · The-Wikipedia-Library
Samwalton9 closed T152324: Integration with the Library Card Platform for user data, a subtask of T152303: Create interface for TWL tracking & reporting of ExternalLinksChange data, as Invalid.
Apr 12 2019, 1:24 PM · The-Wikipedia-Library
Samwalton9 closed T152324: Integration with the Library Card Platform for user data, a subtask of T152325: Partner pages should only show link changes for users with access to that partner, as Invalid.
Apr 12 2019, 1:24 PM · The-Wikipedia-Library
Samwalton9 added a comment to T216031: Royal Society shows "Accounts available: 0 ()".

I think this is because we have collections for this partner, but accounts available is set at the resource-level because it's across all collections. We can just handle the case that a Partner object has accounts_available set but has collections by summing the collection totals and using that as the number distributed.

Apr 12 2019, 12:39 PM · good first bug, Library-Card-Platform

Apr 10 2019

Samwalton9 moved T203770: Set up Matomo from Doing to Planned on the Library-Card-Platform board.
Apr 10 2019, 11:31 AM · Library-Card-Platform

Apr 9 2019

Samwalton9 added a comment to T220138: Automate sending single-use URLs to users.

https://github.com/WikipediaLibrary/TWLight/pull/255

Apr 9 2019, 2:13 PM · Library-Card-Platform
Samwalton9 moved T220138: Automate sending single-use URLs to users from Doing to Done on the Library-Card-Platform board.
Apr 9 2019, 2:13 PM · Library-Card-Platform
Samwalton9 added a comment to T218986: GSoC Proposal: Create a subpage for statistics and charts related to a hashtag search.

Wow - the mockups are looking great!

Apr 9 2019, 10:41 AM · Google-Summer-of-Code (2019)

Apr 8 2019

Samwalton9 added a comment to T220259: GSoC proposal: Create a subpage for statistics and charts related to a hashtag search.

Thanks for your proposal!

Apr 8 2019, 7:04 PM · Google-Summer-of-Code (2019)
Samwalton9 claimed T220138: Automate sending single-use URLs to users.
Apr 8 2019, 12:08 PM · Library-Card-Platform
Samwalton9 renamed T175573: List Applications button should show whitelist for authentication-based partners from 'Download user information csv' button should show whitelist for authentication-based partners to List Applications button should show whitelist for authentication-based partners.
Apr 8 2019, 12:07 PM · Library-Card-Platform-Proxy
Samwalton9 closed T157629: Create an authorization object for user when their application is accepted as Resolved.
Apr 8 2019, 12:06 PM · Library-Card-Platform-Proxy
Samwalton9 closed T157629: Create an authorization object for user when their application is accepted, a subtask of T160288: Create a lightweight Electronic Resource Management (ERM) system, as Resolved.
Apr 8 2019, 12:06 PM · Library-Card-Platform-Proxy
Samwalton9 added a comment to T169204: Users should be able to renew their account in advance of the renewal date.

This should be done in https://github.com/WikipediaLibrary/TWLight/pull/254, but I'll leave this task open so we can make sure the workflow works properly for proxy too.

Apr 8 2019, 12:05 PM · Library-Card-Platform-Proxy
Samwalton9 added a comment to T213091: Re-add optional fixed account lengths.

https://github.com/WikipediaLibrary/TWLight/pull/254

Apr 8 2019, 12:05 PM · Library-Card-Platform
Samwalton9 claimed T206511: Give advance renewal notice for partners with fixed account lengths.

https://github.com/WikipediaLibrary/TWLight/pull/254

Apr 8 2019, 12:05 PM · Library-Card-Platform
Samwalton9 added a comment to T186004: Allow coordinators to customise which types of applications count towards email reminders.

Form and templating useful to this task was added in T206511.

Apr 8 2019, 12:04 PM · Library-Card-Platform
Samwalton9 moved T206511: Give advance renewal notice for partners with fixed account lengths from Open tasks to Done on the Library-Card-Platform board.
Apr 8 2019, 12:03 PM · Library-Card-Platform
Samwalton9 moved T213091: Re-add optional fixed account lengths from Planned to Done on the Library-Card-Platform board.
Apr 8 2019, 12:02 PM · Library-Card-Platform
Samwalton9 closed T219906: Reinstate Authorization in /admin as Resolved.

https://github.com/WikipediaLibrary/TWLight/pull/250

Apr 8 2019, 12:02 PM · Library-Card-Platform
Samwalton9 closed T219773: Tidy up Application-Access Code code as Resolved.
Apr 8 2019, 12:02 PM · Library-Card-Platform
Samwalton9 added a comment to T186706: Create a subpage for statistics and charts related to a hashtag search.

Just a reminder to everyone that the deadline for proposals is tomorrow (Tuesday, April 9) at 18:00 UTC. In addition to a Phabricator task here, you also need to ensure that you've uploaded a PDF version of your proposal to the GSOC website (https://summerofcode.withgoogle.com/) by the deadline!

Apr 8 2019, 9:43 AM · Outreach-Programs-Projects, Google-Summer-of-Code (2019), Hashtags

Apr 4 2019

Samwalton9 created T220138: Automate sending single-use URLs to users.
Apr 4 2019, 6:26 PM · Library-Card-Platform
Samwalton9 added a comment to T171031: Automatically send surveys asking for feedback on partner resources etc..

Meeting notes:

Apr 4 2019, 6:23 PM · Library-Card-Platform
Samwalton9 created T220087: Access code emails don't translate.
Apr 4 2019, 10:49 AM · Library-Card-Platform

Apr 3 2019

Samwalton9 closed T205534: Example data applications should have a possible start date of the import date as Resolved.

Fixed this in https://github.com/WikipediaLibrary/TWLight/pull/242

Apr 3 2019, 3:10 PM · Library-Card-Platform
Samwalton9 claimed T219773: Tidy up Application-Access Code code.

https://github.com/WikipediaLibrary/TWLight/pull/251

Apr 3 2019, 2:59 PM · Library-Card-Platform
Samwalton9 added a comment to T209359: Fix worker timeout issues on production.

PR updated with notes on current progress.

Apr 3 2019, 2:30 PM · Hashtags
Samwalton9 added a comment to T209359: Fix worker timeout issues on production.

Oh actually I've just taken a look and I only committed some of my changes, let me just push my other WIP code.

Apr 3 2019, 2:09 PM · Hashtags
Samwalton9 added a comment to T209359: Fix worker timeout issues on production.

I started working on implementing a proper search engine (https://github.com/Samwalton9/hashtags/pull/22), because I think the core issue here is that we're doing heavy searches directly via Django querysets. I made decent progress, with the primary search functionality up and running - all that's really left to do is reimpliment the top-level statistics that's shown for each search. I just haven't had time to do that yet. If you want to progress that branch please feel free to do so.

Apr 3 2019, 1:05 PM · Hashtags
Samwalton9 added a comment to T207277: Wait for blocking tasks to finish before running next container script.

That Github issue doesn't appear to be relevant as it turned out to be a firewall conflict.

Apr 3 2019, 1:03 PM · Hashtags
Samwalton9 added a comment to T219881: GSoC 2019 Proposal: Create a subpage for statistics and charts related to a hashtag search.

Thanks for this proposal!

Apr 3 2019, 1:00 PM · Google-Summer-of-Code (2019), Hashtags
Samwalton9 added a subtask for T186706: Create a subpage for statistics and charts related to a hashtag search: T219881: GSoC 2019 Proposal: Create a subpage for statistics and charts related to a hashtag search.
Apr 3 2019, 12:55 PM · Outreach-Programs-Projects, Google-Summer-of-Code (2019), Hashtags