Page MenuHomePhabricator

Move count_valid_authorizations from being in to being a Partner model method
Closed, ResolvedPublic


The function count_valid_authorizations is defined in applications/, but its only argument is a partner object. As such it could simply be a method on the Partner model for ease of use and sensible positioning of logic.

Event Timeline

I identified this while working on the above task, where I'm already doing too much refactoring, so parking this slightly-bigger refactor here for later.

Seems like the failing test was unrelated to this PR.

Samwalton9 triaged this task as Low priority.
Samwalton9 moved this task from Ready to Code review on the Moderator-Tools-Team (Kanban) board.
Samwalton9-WMF changed the task status from Open to In Progress.Sep 25 2023, 2:41 PM