The function count_valid_authorizations is defined in applications/helpers.py, but its only argument is a partner object. As such it could simply be a method on the Partner model for ease of use and sensible positioning of logic.
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T240156 Improve Library Card documentation | |||
| Open | None | T207404 Improve developer documentation | |||
| Open | None | T264426 Improve code documentation | |||
| Resolved | Samwalton9 | T264424 Review and expand code documentation for resources | |||
| Open | None | T349553 [EPIC] Moderator Tools Maintenance Work | |||
| Resolved | Samwalton9-WMF | T348541 [Epic] Q2 FY 2023-24 Moderator Tools Maintenance Work | |||
| Resolved | Samwalton9 | T346103 Move count_valid_authorizations from being in applications.helpers.py to being a Partner model method |
Event Timeline
Comment Actions
I identified this while working on the above task, where I'm already doing too much refactoring, so parking this slightly-bigger refactor here for later.
Comment Actions
WIP PR at https://github.com/WikipediaLibrary/TWLight/pull/1209. I'm getting a failing test but can't figure out why.