Page MenuHomePhabricator

Application.DoesNotExist error when users with invalid applications attempt to delete data
Closed, ResolvedPublic

Description

User 2648 tried to delete their user data, but received an internal server error (corresponding GlitchTip issue: https://glitchtip-wikipedialibrary.wmflabs.org/organizations/the-wikipedia-library/issues/458).

The application in question is 15442, which is an Invalid marked application. It looks like when we retrieve a users applications for blanking, we aren't including Invalid applications, which are excluded by default. We should possibly be using include_invalid here.

Event Timeline

Samwalton9-WMF renamed this task from Application.DoesNotExist error when user attempts to delete data to Application.DoesNotExist error when users with invalid applications attempt to delete data.Jun 13 2023, 5:27 PM

I've now resolved the issue for the user described in the original task description, by deleting the Invalid applications. They've confirmed successful deletion of their data.

I was wrong in the task description. The issue was a lack of include_invalid, but it was in emails/tasks.py. Since INVALID isn't a status where we send emails this change makes no difference to the operation of email sending, but does solve this error.

PR: https://github.com/WikipediaLibrary/TWLight/pull/1197

I intended to make the above comments from this account :)