Remove `.firstHeading` selector from core skinning.less
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Volker_E
	Dec 2 2019, 8:03 PM

Description

[[ https://codesearch.wmflabs.org/deployed/?q=.firstHeading&i=nope&files=&repos= | .firstHeading ]] is a skin specific rule and shouldn't be shared across themes.

Vector overrides selector in skin
MinervaNeue/MF is removing it from output
Modern, CologneBlue don't feature the class at all
Timeless doesn't seem to load skinning.less
MonoBook is the only skin that makes use of the class as is, let's copy the rule there.

	Subject	Repo	Branch	Lines +/-
	Amend `firstHeading` selector	mediawiki/skins/MonoBook	master	+3 -1
	Remove `.firstHeading` selector from core	mediawiki/core	master	+0 -4

Change 554141 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Remove .firstHeading selector from core

Change 554147 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/MonoBook@master] Amend firstHeading selector

Change 554141 merged by jenkins-bot:
[mediawiki/core@master] Remove .firstHeading selector from core

Change 554147 merged by jenkins-bot:
[mediawiki/skins/MonoBook@master] Amend firstHeading selector

Volker_E closed this task as Resolved.Dec 2 2019, 9:00 PM

Volker_E claimed this task.