replaceCategoryInPlace doesn't work if left-to-right mark is in the wikitext of the old category name
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	JJMC89
	Dec 7 2019, 9:46 PM

Description

Steps to Reproduce:

python3 pwb.py shell
>>> site = pywikibot.Site('en', 'wikipedia')
>>> text = '[[Category:Ignore me]]\n[[Category:Old\u200e]]'
>>> oldcat = pywikibot.Category(site, 'Old')
>>> newcat = pywikibot.Category(site, 'New')
>>> newtext = pywikibot.textlib.replaceCategoryInPlace(text, oldcat, newcat, site=site)
>>> newtext

Actual Results:

'[[Category:Ignore me]]\n[[Category:Old\u200e]]'

Expected Results:

'[[Category:Ignore me]]\n[[Category:New]]'

Details

	Subject	Repo	Branch	Lines +/-
	[FIX] replaceCategoryInPlace: Allow LRM and RLM at the end of the old_cat title	pywikibot/core	master	+4 -2

Customize query in gerrit

Related Objects

Mentioned In: rPWBCcea537fdd421: [FIX] replaceCategoryInPlace: Allow LRM and RLM at the end of the old_cat title

Event Timeline

JJMC89 created this task.Dec 7 2019, 9:46 PM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptDec 7 2019, 9:46 PM

Maybe it understands it as a part of the category title?

Change 555693 had a related patch set uploaded (by JJMC89; owner: JJMC89):
[pywikibot/core@master] [FIX] replaceCategoryInPlace: Allow LRM and RLM at the end of the old category name

https://gerrit.wikimedia.org/r/555693

gerritbot added a project: Patch-For-Review.Dec 7 2019, 10:09 PM

JJMC89 claimed this task.Dec 7 2019, 10:10 PM

Xqt closed this task as Resolved.Dec 8 2019, 12:38 PM

Change 555693 merged by jenkins-bot:
[pywikibot/core@master] [FIX] replaceCategoryInPlace: Allow LRM and RLM at the end of the old_cat title

https://gerrit.wikimedia.org/r/555693

JJMC89 mentioned this in rPWBCcea537fdd421: [FIX] replaceCategoryInPlace: Allow LRM and RLM at the end of the old_cat title.Dec 8 2019, 12:44 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 8 2019, 1:10 PM

replaceCategoryInPlace doesn't work if left-to-right mark is in the wikitext of the old category nameClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related Objects

Event Timeline

replaceCategoryInPlace doesn't work if left-to-right mark is in the wikitext of the old category name
Closed, ResolvedPublicBUG REPORT
Actions