Page MenuHomePhabricator

Datepicker disappeared in ticket editing interface
Closed, ResolvedPublic

Assigned To
Authored By
Urbanecm
Dec 23 2019, 11:11 PM
Referenced Files
F31488537: Screenshot_20191225_132922.png
Dec 25 2019, 12:30 PM
F31487996: image.png
Dec 24 2019, 9:24 PM
F31487998: image.png
Dec 24 2019, 9:24 PM
F31486976: image.png
Dec 23 2019, 11:11 PM

Description

Problem

Up until recently, ticket editing interface (/ticket/75/edit/) allowed users to pick dates easily with a datepicker. See Phabricator for screenshot.
 

Outcome

Investigate why datepicker doesn't appear anymore. For this task to be considered completed, you don't have to find out the root case, you must, however, make geniune effort to investigate. Document what you did, in the case you won't success, the documentation will be important for further developers.
 
If you manage to fix the error, you are expected to send a patch for wikimedia-cz/tracker repository, hosted at Wikimedia Gerrit. When claiming task on GCI website, student should claim a respective Phabricator task as well.
 

Materials

 

Screenshot

image.png (474×1 px, 43 KB)

In the circled part of interface there used to be a datepicker button.

Event Timeline

This patch that I sent two days ago should fix it.

Change 560315 had a related patch set uploaded (by Alcarazzam; owner: Alcarazzam):
[wikimedia-cz/tracker@master] Fix jquery url and other small changes

https://gerrit.wikimedia.org/r/560315

Change 560315 merged by jenkins-bot:
[wikimedia-cz/tracker@master] Fix jquery url and other small changes

https://gerrit.wikimedia.org/r/560315

This patch that I sent two days ago should fix it.

Maybe should, but doesn't - merged anyway. Deployed to both test and prod.

Change 560543 had a related patch set uploaded (by Alcarazzam; owner: Alcarazzam):
[wikimedia-cz/tracker@master] Fix datepicker disappeared in ticket editing interface

https://gerrit.wikimedia.org/r/560543

This patch that I sent two days ago should fix it.

Maybe should, but doesn't - merged anyway. Deployed to both test and prod.

Now it's really fixed

Indeed, however, it changes appearance of the edit interface.

Production:

image.png (850×1 px, 115 KB)

Local with your patch applied:

image.png (785×1 px, 92 KB)

Could you please make it work without altering the appearance of the interface? Thanks!

The links? It should be a property in the added CSS, so adding an !important; should be enough. I'll try tomorrow.

The links? It should be a property in the added CSS, so adding an !important; should be enough. I'll try tomorrow.

Not sure what you mean by the links, if you mean where the screenshots come, http://localhost:8000/ticket/1/edit/. If you ask what is the difference, the font is different, headline is styled differently etc.

Change 560543 merged by jenkins-bot:
[wikimedia-cz/tracker@master] Fix datepicker disappeared in ticket editing & adding interface

https://gerrit.wikimedia.org/r/560543