Page MenuHomePhabricator

E-Mail notification message text enotif_body needs to be updated (patch)
Closed, ResolvedPublic

Description

Since the introduction in REL_1.6 in 2006, the e-mail notification message body template remained unchanged. Now it is possible to improve the message template by using newer internal variables. (Module UserMailer.php could be deliberately modified accordingly, so to skip calculation of the now-unneeded variable $PAGETITLE and $PAGETITLE_URL)

I also added a direct link for action=unwatch in the mail footer which helps users to immediately stop watching without visiting that page (in case they want to stop further notifications for that page).


Version: 1.16.x
Severity: normal

Details

Reference
bz22222

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:53 PM
bzimport added a project: MediaWiki-Email.
bzimport set Reference to bz22222.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 7004
diff patch

Attached:

The {{FULLPAGENAME}} are in fact more costly than $PAGETITLE (which should still be accepted for bc).

I also added a direct link for action=unwatch in the mail footer which helps
users to immediately stop watching without visiting that page (in case they
want to stop further notifications for that page).

Is it really needed? "There will be no other notifications in case of further changes unless you visit this page.", and there's already a link to Special:Watchlist/edit. I'm unsure about it.

Thanks for your contribution anyway.

I (as co-contributor of Enotif) find it very useful to have a direct link to unwatch a page.

As mentioned, it saves any further viewing of pages or watchlist access, thus it is a perfect single-click solution to "get rid" of obsolete watches at the moment you receive a notification (try it: on commons and on mediawiki, the E-Mail notification is enabled). Because the url and the action is clear, almost no further processing load is needed.

Moreover, the proposed additional unwatch line can by easily removed by editing MediaWiki:Enotif_body if wanted by a sysop. That's my rationale to propose it now as a useful addition.

(In reply to comment #2)

The {{FULLPAGENAME}} are in fact more costly than $PAGETITLE (which should
still be accepted for bc).

I was _not_ aware of this fact, but to have two different things for the same result isn't that nice, is it? When it was designed, I had no other chance of self-calculation $PAGETITLE and $PAGETITLE_URL .

So, I would agree, to let the message as it is (and to close this bug as NOFIX).

Added the unwatch link on r61367