Page MenuHomePhabricator

Allow backslash and dollar character in external links parser
Closed, ResolvedPublic

Description

Author: Michael.Keppler

Description:
Please add "\" and "$" to the external links parser to make the software usable
in Windows based intranets. "\" is needed for host based pathes like
\\servername\path\file and the "$" character is used for "hidden" network shares
in Windows.
This can be accomplished by changing function subReplaceExternalLinks in
includes\parser.php, so that

		$uc = "A-Za-z0-9_\\/~%\\-+&*#?!=()@\\x80-\\xFF\\\\\\$";

instead of

		$uc = "A-Za-z0-9_\\/~%\\-+&*#?!=()@\\x80-\\xFF";

where the change is "\\\\" and "\\$" and by

		$fnc = 'A-Za-z0-9_.,~%\\-+&;#*?!=()@\\x80-\\xFF\\\\\\$';

instead of

		$fnc = 'A-Za-z0-9_.,~%\\-+&;#*?!=()@\\x80-\\xFF';

With these changes the software works fine in a Windows installation at our company.


Version: 1.3.x
Severity: enhancement
OS: Windows 2000
Platform: PC

Details

Reference
bz430

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 6:55 PM
bzimport set Reference to bz430.
bzimport added a subscriber: Unknown Object (MLST).
  • This bug has been marked as a duplicate of 343 ***