Page MenuHomePhabricator

CentrlAuth db_patches inconsistent to centralauth.sql
Closed, ResolvedPublic

Description

Whereas central-auth.sql has the usual /*_*/ and /*i*/ throughout, numerous files in db_patches do not, which is non standard

There's also other inconsistencies, like how indexes and PK are defined

Event Timeline

Reedy created this task.Feb 22 2020, 5:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 22 2020, 5:02 PM
Reedy renamed this task from CentrlAuth db_patches inconsistently have comment prefixes to CentrlAuth db_patches inconsistent to centralauth.sql.Feb 22 2020, 5:14 PM
Reedy updated the task description. (Show Details)

Change 574189 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/CentralAuth@master] Make CentralAuth schema patches consistent

https://gerrit.wikimedia.org/r/574189

Change 574189 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Make CentralAuth schema patches consistent to canonical file

https://gerrit.wikimedia.org/r/574189

Reedy closed this task as Resolved.Mar 8 2020, 11:02 PM
Reedy claimed this task.