Page MenuHomePhabricator
Create Task
Maniphest T246581

`smwgContLang` removed from Semantic MediaWiki codebase
Closed, ResolvedPublic
Actions

Description

smwgContLang, unreferenced since Semantic MediaWiki 2.5.0 was removed from Semantic MediaWiki code base effective with release 3.2.0. The code search shows that it is still used by Semantic Drilldown. Instead the smwfContLang() function is provided. It will be great if the code will be adapted.

Related Objects

Event Timeline

Kghbln created this task.Mar 1 2020, 4:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 1 2020, 4:43 PM
Ivanhercaz subscribed.Oct 8 2020, 4:02 PM
Ivanhercaz mentioned this in T265059: SD_Filter.php: Call to a member function getDatatypeLabels() on null.Oct 8 2020, 4:53 PM
Ivanhercaz added a comment.Oct 9 2020, 5:57 PM

@Kghbln, I think this issue should be marked as resolved due T265059#6533166. The patch provides backward compatibility with SMW < 3.2, so I think it isn't necessary to remove the reference from .phpcs.xml.

Kghbln closed this task as Resolved.Oct 10 2020, 10:20 AM
Kghbln assigned this task to InvalidOS.
Kghbln reassigned this task from InvalidOS to Ivanhercaz.
Kghbln added a subscriber: InvalidOS.

I guess so. Thanks for poking at the issue.

Kghbln removed a subscriber: InvalidOS.Oct 10 2020, 10:21 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits