Page MenuHomePhabricator
Create Task
Maniphest T249031

Hard deprecate MessageCache::singleton and remove a release later
Closed, ResolvedPublic
Actions

Description

MessageCache::singleton is only used in fallback code for older versions and could be hard deprecated.

https://codesearch.wmflabs.org/search/?q=MessageCache%5Cs*%3A%3A%5Cs*singleton&i=fosho&files=&repos=

Details

SubjectRepoBranchLines +/-
Remove MessageCache::singleton()mediawiki/coremaster+1 -14
Hard deprecate MessageCache::singleton()mediawiki/coremaster+6 -1
Customize query in gerrit

Event Timeline

Umherirrender created this task.Mar 31 2020, 6:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2020, 6:14 PM
Aklapper edited projects, added MediaWiki-Parser; removed MediaWiki-General.Apr 1 2020, 12:27 PM
Zabe claimed this task.May 3 2021, 12:59 PM
Zabe added a project: User-Zabe.
Zabe subscribed.
gerritbot added a comment.May 3 2021, 1:09 PM

Change 684392 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Hard deprecate MessageCache::singleton()

https://gerrit.wikimedia.org/r/684392

gerritbot added a project: Patch-For-Review.May 3 2021, 1:09 PM
gerritbot added a comment.May 3 2021, 4:16 PM

Change 684392 merged by jenkins-bot:

[mediawiki/core@master] Hard deprecate MessageCache::singleton()

https://gerrit.wikimedia.org/r/684392

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).May 3 2021, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 3 2021, 5:10 PM
Zabe moved this task from Backlog to Deprecation on the User-Zabe board.May 6 2021, 10:52 AM
gerritbot added a comment.Sep 15 2021, 4:14 PM

Change 721348 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Remove MessageCache::singleton()

https://gerrit.wikimedia.org/r/721348

gerritbot added a project: Patch-For-Review.Sep 15 2021, 4:14 PM
gerritbot added a comment.Sep 16 2021, 2:52 AM

Change 721348 merged by jenkins-bot:

[mediawiki/core@master] Remove MessageCache::singleton()

https://gerrit.wikimedia.org/r/721348

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.1; 2021-09-21).Sep 16 2021, 3:00 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 16 2021, 3:10 AM
Zabe closed this task as Resolved.Sep 16 2021, 5:47 AM
Zabe removed a project: User-Zabe.Apr 13 2022, 1:21 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits