Replace trigger() with triggerHandler() in tests
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Sebastian_Berlin-WMSE
	Apr 1 2020, 1:35 PM

Description

Replace the use of trigger() with triggerHandler() in Javascript tests. This should minimize unwanted side effects. There have also been some issues with tests not running locally that are solved with this change.

Details

	Subject	Repo	Branch	Lines +/-
	Make sure that utterance audio is loaded before playing	mediawiki/extensions/Wikispeech	master	+185 -152

Customize query in gerrit

Related Objects

Mentioned In: rEWIS623dedbaf3f7: Make sure that utterance audio is loaded before playing

Event Timeline

Sebastian_Berlin-WMSE created this task.Apr 1 2020, 1:35 PM

Restricted Application added a project: Wikispeech-Jobrunner. · View Herald TranscriptApr 1 2020, 1:35 PM

Sebastian_Berlin-WMSE moved this task from Incoming to Backlog on the Wikispeech-Jobrunner board.Apr 2 2020, 9:10 AM

Change 699426 had a related patch set uploaded (by Sebastian Berlin (WMSE); author: Sebastian Berlin (WMSE)):

[mediawiki/extensions/Wikispeech@master] Make sure that utterance audio is loaded before playing

https://gerrit.wikimedia.org/r/699426

gerritbot added a project: Patch-For-Review.Jun 11 2021, 2:35 PM

Change 699426 merged by jenkins-bot: