Page MenuHomePhabricator

$wgPageFormsUseDisplayTitle interferes with autocompletion using values_from_concept when Display_title_of not set
Closed, ResolvedPublicBUG REPORT

Description

Steps to Reproduce:

  • Have $wgPageFormsUseDisplayTitle = true
  • Run a pfautocomplete API query (a`pi.php?action=pfautocomplete&format=json&concept=example&substr=Ex`)

Actual Results:

  • Empty result set returned

Expected Results:

  • For pages that have the Display_title_of set, this value should be used for the substring comparison
  • For pages that do not have the Display_title_of set, the title should be used

Generally, the issue seems to originate from the fact that when $wgPageFormsUseDisplayTitle = true PageForms expects SMW to set Display_title_of for every single page. Pages that do not have that property set are ignored. However, SMW only does so when {{DISPLAYTITLE:title to be displayed}} is set.

Event Timeline

Change 591208 had a related patch set uploaded (by Antoine Mercier-Linteau; owner: Antoine Mercier-Linteau):
[mediawiki/extensions/PageForms@master] values_from_concept not searching normal titles

https://gerrit.wikimedia.org/r/591208

@Tinss - That's a good find. I made some changes to the code and commit message for your patch (Page Forms doesn't use "Display title of"), but the basic idea is the same. Please let me know if this is still alright.

@Yaron_Koren, thanks a bunch. I'll let you +2 the changes on gerrit and close this task.

Change 591208 merged by jenkins-bot:
[mediawiki/extensions/PageForms@master] Fix for values_from_concept not returning pages with no display title

https://gerrit.wikimedia.org/r/591208

Yaron_Koren claimed this task.